Merge pull request #20 from RussellRollins/remove-extraneous-else

mhagger · web-flow · commit 42b73da1fec4 · 2018-03-09T13:26:24.000+01:00
This return can be a fallthrough w/o an else.
diff --git a/sizes/output.go b/sizes/output.go
@@ -194,9 +194,8 @@ func (l *item) levelOfConcern(t *table) (string, bool) {
 	}
 	if alert > 30 {
 		return "!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!", true
-	} else {
-		return stars[:int(alert)], true
 	}
+	return stars[:int(alert)], true
 }
 
 type Threshold float64

Original file line number	Diff line number	Diff line change
`@@ -194,9 +194,8 @@ func (l item) levelOfConcern(t table) (string, bool) {`
`194`	`194`	`}`
`195`	`195`	`if alert > 30 {`
`196`	`196`	`return "!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!", true`
`197`		`- } else {`
`198`		`- return stars[:int(alert)], true`
`199`	`197`	`}`
	`198`	`+ return stars[:int(alert)], true`
`200`	`199`	`}`
`201`	`200`
`202`	`201`	`type Threshold float64`