table.String(), table.generateLines(): inline methods

mhagger · mhagger · commit c88525bdee3e · 2018-08-20T22:24:04.000+02:00
diff --git a/sizes/output.go b/sizes/output.go
@@ -330,11 +330,9 @@ func (s HistorySize) TableString(threshold Threshold, nameStyle NameStyle) strin
 		footnotes: NewFootnotes(),
 	}
 
-	return t.String()
-}
-
-func (t *table) String() string {
-	linesString := t.generateLines()
+	buf := &bytes.Buffer{}
+	t.contents.Emit(&t, buf, -1)
+	linesString := buf.String()
 	return linesString + t.footnotes.String()
 }
 
@@ -345,12 +343,6 @@ func (t *table) generateHeader() string {
 	return buf.String()
 }
 
-func (t *table) generateLines() string {
-	buf := &bytes.Buffer{}
-	t.contents.Emit(t, buf, -1)
-	return buf.String()
-}
-
 func (t *table) emitBlankRow(buf io.Writer) {
 	t.formatRow(buf, 0, "", "", "", "", "")
 }

Original file line number	Diff line number	Diff line change
`@@ -330,11 +330,9 @@ func (s HistorySize) TableString(threshold Threshold, nameStyle NameStyle) strin`
`330`	`330`	`footnotes: NewFootnotes(),`
`331`	`331`	`}`
`332`	`332`
`333`		`- return t.String()`
`334`		`-}`
`335`		`-`
`336`		`-func (t *table) String() string {`
`337`		`- linesString := t.generateLines()`
	`333`	`+ buf := &bytes.Buffer{}`
	`334`	`+ t.contents.Emit(&t, buf, -1)`
	`335`	`+ linesString := buf.String()`
`338`	`336`	`return linesString + t.footnotes.String()`
`339`	`337`	`}`
`340`	`338`
`@@ -345,12 +343,6 @@ func (t *table) generateHeader() string {`
`345`	`343`	`return buf.String()`
`346`	`344`	`}`
`347`	`345`
`348`		`-func (t *table) generateLines() string {`
`349`		`- buf := &bytes.Buffer{}`
`350`		`- t.contents.Emit(t, buf, -1)`
`351`		`- return buf.String()`
`352`		`-}`
`353`		`-`
`354`	`346`	`func (t *table) emitBlankRow(buf io.Writer) {`
`355`	`347`	`t.formatRow(buf, 0, "", "", "", "", "")`
`356`	`348`	`}`