lint: type assertion in RequiredParam

LuluBeatson · LuluBeatson · commit 0cc0840bd999 · 2025-06-09T13:33:37.000+01:00
diff --git a/pkg/github/server.go b/pkg/github/server.go
@@ -74,16 +74,16 @@ func RequiredParam[T comparable](r mcp.CallToolRequest, p string) (T, error) {
 	}
 
 	// Check if the parameter is of the expected type
-	if _, ok := r.GetArguments()[p].(T); !ok {
+	val, ok := r.GetArguments()[p].(T)
+	if !ok {
 		return zero, fmt.Errorf("parameter %s is not of type %T", p, zero)
 	}
 
-	if r.GetArguments()[p].(T) == zero {
+	if val == zero {
 		return zero, fmt.Errorf("missing required parameter: %s", p)
-
 	}
 
-	return r.GetArguments()[p].(T), nil
+	return val, nil
 }
 
 // RequiredInt is a helper function that can be used to fetch a requested parameter from the request.

Original file line number	Diff line number	Diff line change
`@@ -74,16 +74,16 @@ func RequiredParam[T comparable](r mcp.CallToolRequest, p string) (T, error) {`
`74`	`74`	`}`
`75`	`75`
`76`	`76`	`// Check if the parameter is of the expected type`
`77`		`- if _, ok := r.GetArguments()[p].(T); !ok {`
	`77`	`+ val, ok := r.GetArguments()[p].(T)`
	`78`	`+ if !ok {`
`78`	`79`	`return zero, fmt.Errorf("parameter %s is not of type %T", p, zero)`
`79`	`80`	`}`
`80`	`81`
`81`		`- if r.GetArguments()[p].(T) == zero {`
	`82`	`+ if val == zero {`
`82`	`83`	`return zero, fmt.Errorf("missing required parameter: %s", p)`
`83`		`-`
`84`	`84`	`}`
`85`	`85`
`86`		`- return r.GetArguments()[p].(T), nil`
	`86`	`+ return val, nil`
`87`	`87`	`}`
`88`	`88`
`89`	`89`	`// RequiredInt is a helper function that can be used to fetch a requested parameter from the request.`