Skip to content

Commit 278b94e

Browse files
committed
remove incorrect diff param
1 parent bf3e789 commit 278b94e

File tree

3 files changed

+4
-32
lines changed

3 files changed

+4
-32
lines changed

pkg/github/__toolsnaps__/list_commits.snap

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,6 @@
1010
"description": "Author username or email address to filter commits by",
1111
"type": "string"
1212
},
13-
"include_diffs": {
14-
"description": "Whether to include file diffs and stats in the response. Default is false for faster responses.",
15-
"type": "boolean"
16-
},
1713
"owner": {
1814
"description": "Repository owner",
1915
"type": "string"

pkg/github/repositories.go

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -213,9 +213,6 @@ func ListCommits(getClient GetClientFn, t translations.TranslationHelperFunc) (t
213213
mcp.WithString("author",
214214
mcp.Description("Author username or email address to filter commits by"),
215215
),
216-
mcp.WithBoolean("include_diffs",
217-
mcp.Description("Whether to include file diffs and stats in the response. Default is false for faster responses."),
218-
),
219216
WithPagination(),
220217
),
221218
func(ctx context.Context, request mcp.CallToolRequest) (*mcp.CallToolResult, error) {
@@ -235,10 +232,6 @@ func ListCommits(getClient GetClientFn, t translations.TranslationHelperFunc) (t
235232
if err != nil {
236233
return mcp.NewToolResultError(err.Error()), nil
237234
}
238-
includeDiffs, err := OptionalParam[bool](request, "include_diffs")
239-
if err != nil {
240-
return mcp.NewToolResultError(err.Error()), nil
241-
}
242235
pagination, err := OptionalPaginationParams(request)
243236
if err != nil {
244237
return mcp.NewToolResultError(err.Error()), nil
@@ -282,7 +275,7 @@ func ListCommits(getClient GetClientFn, t translations.TranslationHelperFunc) (t
282275
// Convert to minimal commits
283276
minimalCommits := make([]MinimalCommit, 0, len(commits))
284277
for _, commit := range commits {
285-
minimalCommits = append(minimalCommits, convertToMinimalCommit(commit, includeDiffs))
278+
minimalCommits = append(minimalCommits, convertToMinimalCommit(commit, false))
286279
}
287280

288281
r, err := json.Marshal(minimalCommits)

pkg/github/repositories_test.go

Lines changed: 3 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -720,7 +720,6 @@ func Test_ListCommits(t *testing.T) {
720720
assert.Contains(t, tool.InputSchema.Properties, "repo")
721721
assert.Contains(t, tool.InputSchema.Properties, "sha")
722722
assert.Contains(t, tool.InputSchema.Properties, "author")
723-
assert.Contains(t, tool.InputSchema.Properties, "include_diffs")
724723
assert.Contains(t, tool.InputSchema.Properties, "page")
725724
assert.Contains(t, tool.InputSchema.Properties, "perPage")
726725
assert.ElementsMatch(t, tool.InputSchema.Required, []string{"owner", "repo"})
@@ -931,25 +930,9 @@ func Test_ListCommits(t *testing.T) {
931930
assert.Equal(t, tc.expectedCommits[i].Author.GetLogin(), commit.Author.Login)
932931
}
933932

934-
// Check if diffs are included based on include_diffs parameter
935-
includeDiffs, exists := tc.requestArgs["include_diffs"]
936-
if exists && includeDiffs == true {
937-
// When include_diffs=true, files and stats should be present
938-
if len(tc.expectedCommits[i].Files) > 0 {
939-
assert.NotNil(t, commit.Files)
940-
assert.Len(t, commit.Files, len(tc.expectedCommits[i].Files))
941-
}
942-
if tc.expectedCommits[i].Stats != nil {
943-
assert.NotNil(t, commit.Stats)
944-
assert.Equal(t, tc.expectedCommits[i].Stats.GetAdditions(), commit.Stats.Additions)
945-
assert.Equal(t, tc.expectedCommits[i].Stats.GetDeletions(), commit.Stats.Deletions)
946-
assert.Equal(t, tc.expectedCommits[i].Stats.GetTotal(), commit.Stats.Total)
947-
}
948-
} else {
949-
// When include_diffs=false or not specified (default is false for performance), files and stats should not be present
950-
assert.Nil(t, commit.Files)
951-
assert.Nil(t, commit.Stats)
952-
}
933+
// Files and stats are never included in list_commits (only available in individual commit queries)
934+
assert.Nil(t, commit.Files)
935+
assert.Nil(t, commit.Stats)
953936
}
954937
})
955938
}

0 commit comments

Comments
 (0)