Default to ignore unknown toolsets

Author: omgitsads

internal/ghmcp/server.go

@@ -17,7 +17,6 @@ import (
 	"github.com/github/github-mcp-server/pkg/github"
 	mcplog "github.com/github/github-mcp-server/pkg/log"
 	"github.com/github/github-mcp-server/pkg/raw"
-	"github.com/github/github-mcp-server/pkg/toolsets"
 	"github.com/github/github-mcp-server/pkg/translations"
 	gogithub "github.com/google/go-github/v74/github"
 	"github.com/mark3labs/mcp-go/mcp"
@@ -143,7 +142,7 @@ func NewMCPServer(cfg MCPServerConfig) (*server.MCPServer, error) {
 
 	// Create default toolsets
 	tsg := github.DefaultToolsetGroup(cfg.ReadOnly, getClient, getGQLClient, getRawClient, cfg.Translator, cfg.ContentWindowSize)
-	err = tsg.EnableToolsets(enabledToolsets, &toolsets.EnableToolsetsOptions{})
+	err = tsg.EnableToolsets(enabledToolsets, nil)
 
 	if err != nil {
 		return nil, fmt.Errorf("failed to enable toolsets: %w", err)

pkg/toolsets/toolsets.go

@@ -210,7 +210,7 @@ type EnableToolsetsOptions struct {
 func (tg *ToolsetGroup) EnableToolsets(names []string, options *EnableToolsetsOptions) error {
 	if options == nil {
 		options = &EnableToolsetsOptions{
-			IgnoreUnknown: false,
+			IgnoreUnknown: true,
 		}
 	}
 

pkg/toolsets/toolsets_test.go

@@ -148,19 +148,26 @@ func TestEnableToolsets(t *testing.T) {
 	}
 
 	// Test with non-existent toolset in the list
-	err = tsg.EnableToolsets([]string{"toolset1", "non-existent"}, &EnableToolsetsOptions{})
+	err = tsg.EnableToolsets([]string{"toolset1", "non-existent"}, nil)
+	if err != nil {
+		t.Errorf("Expected no error when ignoring unknown toolsets, got: %v", err)
+	}
+
+	err = tsg.EnableToolsets([]string{"toolset1", "non-existent"}, &EnableToolsetsOptions{
+		IgnoreUnknown: true,
+	})
+	if err != nil {
+		t.Errorf("Expected no error when ignoring unknown toolsets, got: %v", err)
+	}
+
+	err = tsg.EnableToolsets([]string{"toolset1", "non-existent"}, &EnableToolsetsOptions{IgnoreUnknown: false})
 	if err == nil {
 		t.Error("Expected error when enabling list with non-existent toolset")
 	}
 	if !errors.Is(err, NewToolsetDoesNotExistError("non-existent")) {
 		t.Errorf("Expected ToolsetDoesNotExistError when enabling non-existent toolset, got: %v", err)
 	}
 
-	err = tsg.EnableToolsets([]string{"toolset1", "non-existent"}, &EnableToolsetsOptions{IgnoreUnknown: true})
-	if err != nil {
-		t.Errorf("Expected no error when ignoring unknown toolsets, got: %v", err)
-	}
-
 	// Test with empty list
 	err = tsg.EnableToolsets([]string{}, &EnableToolsetsOptions{})
 	if err != nil {