Minor tweaks

Author: JoannaaKL

pkg/github/__toolsnaps__/get_project.snap

@@ -3,7 +3,7 @@
     "title": "Get project",
     "readOnlyHint": true
   },
-  "description": "Get Project for a user or organization",
+  "description": "Get Project for an user or organization",
   "inputSchema": {
     "properties": {
       "owner": {

pkg/github/projects.go

@@ -42,7 +42,6 @@ func ListProjects(getClient GetClientFn, t translations.TranslationHelperFunc) (
 			if err != nil {
 				return mcp.NewToolResultError(err.Error()), nil
 			}
-
 			client, err := getClient(ctx)
 			if err != nil {
 				return mcp.NewToolResultError(err.Error()), nil
@@ -56,11 +55,14 @@ func ListProjects(getClient GetClientFn, t translations.TranslationHelperFunc) (
 			}
 			projects := []github.ProjectV2{}
 
-			opts := ListProjectsOptions{PerPage: perPage}
+			opts := listProjectsOptions{PerPage: perPage}
 
 			if queryStr != "" {
 				opts.Query = queryStr
 			}
+			if perPage > 0 {
+				opts.PerPage = perPage
+			}
 			url, err = addOptions(url, opts)
 			if err != nil {
 				return nil, fmt.Errorf("failed to add options to request: %w", err)
@@ -99,7 +101,7 @@ func ListProjects(getClient GetClientFn, t translations.TranslationHelperFunc) (
 
 func GetProject(getClient GetClientFn, t translations.TranslationHelperFunc) (tool mcp.Tool, handler server.ToolHandlerFunc) {
 	return mcp.NewTool("get_project",
-			mcp.WithDescription(t("TOOL_GET_PROJECT_DESCRIPTION", "Get Project for a user or organization")),
+			mcp.WithDescription(t("TOOL_GET_PROJECT_DESCRIPTION", "Get Project for an user or organization")),
 			mcp.WithToolAnnotation(mcp.ToolAnnotation{Title: t("TOOL_GET_PROJECT_USER_TITLE", "Get project"), ReadOnlyHint: ToBoolPtr(true)}),
 			mcp.WithNumber("project_number", mcp.Required(), mcp.Description("The project's number")),
 			mcp.WithString("owner_type", mcp.Required(), mcp.Description("Owner type"), mcp.Enum("user", "organization")),
@@ -133,14 +135,14 @@ func GetProject(getClient GetClientFn, t translations.TranslationHelperFunc) (to
 				url = fmt.Sprintf("users/%s/projectsV2/%d", owner, projectNumber)
 			}
 
-			projects := []github.ProjectV2{}
+			project := github.ProjectV2{}
 
 			httpRequest, err := client.NewRequest("GET", url, nil)
 			if err != nil {
 				return nil, fmt.Errorf("failed to create request: %w", err)
 			}
 
-			resp, err := client.Do(ctx, httpRequest, &projects)
+			resp, err := client.Do(ctx, httpRequest, &project)
 			if err != nil {
 				return ghErrors.NewGitHubAPIErrorResponse(ctx,
 					"failed to get project",
@@ -157,7 +159,7 @@ func GetProject(getClient GetClientFn, t translations.TranslationHelperFunc) (to
 				}
 				return mcp.NewToolResultError(fmt.Sprintf("failed to get project: %s", string(body))), nil
 			}
-			r, err := json.Marshal(projects)
+			r, err := json.Marshal(project)
 			if err != nil {
 				return nil, fmt.Errorf("failed to marshal response: %w", err)
 			}
@@ -166,7 +168,7 @@ func GetProject(getClient GetClientFn, t translations.TranslationHelperFunc) (to
 		}
 }
 
-type ListProjectsOptions struct {
+type listProjectsOptions struct {
 	// For paginated result sets, the number of results to include per page.
 	PerPage int `url:"per_page,omitempty"`
 

pkg/github/projects_test.go

@@ -15,7 +15,6 @@ import (
 )
 
 func Test_ListProjects(t *testing.T) {
-	// Verify tool definition and schema once
 	mockClient := gh.NewClient(nil)
 	tool, _ := ListProjects(stubGetClientFn(mockClient), translations.NullTranslationHelper)
 	require.NoError(t, toolsnaps.Test(tool.Name, tool))
@@ -28,7 +27,6 @@ func Test_ListProjects(t *testing.T) {
 	assert.Contains(t, tool.InputSchema.Properties, "per_page")
 	assert.ElementsMatch(t, tool.InputSchema.Required, []string{"owner", "owner_type"})
 
-	// Minimal project objects (fields chosen to likely exist on ProjectV2; test only asserts round-trip JSON array length)
 	orgProjects := []map[string]any{{"id": 1, "title": "Org Project"}}
 	userProjects := []map[string]any{{"id": 2, "title": "User Project"}}
 
@@ -176,15 +174,13 @@ func Test_GetProject(t *testing.T) {
 	assert.Contains(t, tool.InputSchema.Properties, "owner_type")
 	assert.ElementsMatch(t, tool.InputSchema.Required, []string{"project_number", "owner", "owner_type"})
 
-	// Minimal project object for response array
-	project := []map[string]any{{"id": 123, "title": "Project Title"}}
+	project := map[string]any{"id": 123, "title": "Project Title"}
 
 	tests := []struct {
 		name           string
 		mockedClient   *http.Client
 		requestArgs    map[string]interface{}
 		expectError    bool
-		expectedLength int
 		expectedErrMsg string
 	}{
 		{
@@ -200,8 +196,7 @@ func Test_GetProject(t *testing.T) {
 				"owner":          "octo-org",
 				"owner_type":     "organization",
 			},
-			expectError:    false,
-			expectedLength: 1,
+			expectError: false,
 		},
 		{
 			name: "success user project fetch",
@@ -216,8 +211,7 @@ func Test_GetProject(t *testing.T) {
 				"owner":          "octocat",
 				"owner_type":     "user",
 			},
-			expectError:    false,
-			expectedLength: 1,
+			expectError: false,
 		},
 		{
 			name: "api error",
@@ -292,10 +286,9 @@ func Test_GetProject(t *testing.T) {
 
 			require.False(t, result.IsError)
 			textContent := getTextResult(t, result)
-			var arr []map[string]any
+			var arr map[string]any
 			err = json.Unmarshal([]byte(textContent.Text), &arr)
 			require.NoError(t, err)
-			assert.Equal(t, tc.expectedLength, len(arr))
 		})
 	}
 }