refactor docs toolset gen

Author: mattdholloway

cmd/github-mcp-server/generate_docs.go

@@ -1,6 +1,7 @@
 package main
 
 import (
+	"context"
 	"fmt"
 	"net/url"
 	"os"
@@ -50,8 +51,10 @@ func generateReadmeDocs(readmePath string) error {
 	// Create translation helper
 	t, _ := translations.TranslationHelper()
 
-	// Build inventory - stateless, no dependencies needed for doc generation
-	r := github.NewInventory(t).Build()
+	// Build inventory with all toolsets enabled and no feature checker (all flags return false).
+	// This includes tools from all toolsets, but excludes tools with FeatureFlagEnable
+	// (not available to regular users) while including tools with FeatureFlagDisable.
+	r := github.NewInventory(t).WithToolsets([]string{"all"}).Build()
 
 	// Generate toolsets documentation
 	toolsetsDoc := generateToolsetsDoc(r)
@@ -153,10 +156,10 @@ func generateToolsetsDoc(i *inventory.Inventory) string {
 }
 
 func generateToolsDoc(r *inventory.Inventory) string {
-	// AllToolsForDocs() returns tools sorted by toolset ID then tool name,
-	// excluding tools that require feature flags (not available to regular users).
-	// We iterate once, grouping by toolset as we encounter them.
-	tools := r.AllToolsForDocs()
+	// Use AvailableTools with the inventory's feature checker (returns false for all flags),
+	// which excludes tools requiring a feature flag (FeatureFlagEnable) while keeping
+	// tools that are disabled by feature flags (available by default).
+	tools := r.AvailableTools(context.Background())
 	if len(tools) == 0 {
 		return ""
 	}

pkg/inventory/registry.go

@@ -266,33 +266,6 @@ func (r *Inventory) AllTools() []ServerTool {
 	return result
 }
 
-// AllToolsForDocs returns tools suitable for documentation, sorted deterministically.
-// This excludes tools that require a feature flag to be enabled (FeatureFlagEnable),
-// since those are not available to regular users and shouldn't appear in public docs.
-// Tools that are disabled by a feature flag (FeatureFlagDisable) are still included
-// since they are available by default.
-func (r *Inventory) AllToolsForDocs() []ServerTool {
-	var result []ServerTool
-	for i := range r.tools {
-		tool := &r.tools[i]
-		// Skip tools that require a feature flag to enable
-		if tool.FeatureFlagEnable != "" {
-			continue
-		}
-		result = append(result, *tool)
-	}
-
-	// Sort deterministically: by toolset ID, then by tool name
-	sort.Slice(result, func(i, j int) bool {
-		if result[i].Toolset.ID != result[j].Toolset.ID {
-			return result[i].Toolset.ID < result[j].Toolset.ID
-		}
-		return result[i].Tool.Name < result[j].Tool.Name
-	})
-
-	return result
-}
-
 // AvailableToolsets returns the unique toolsets that have tools, in sorted order.
 // This is the ordered intersection of toolsets with reality - only toolsets that
 // actually contain tools are returned, sorted by toolset ID.