Switch to getClient idiom

Author: danielssonsimonbcg

pkg/github/organizations.go

@@ -13,7 +13,7 @@ import (
 )
 
 // ListCommits creates a tool to get commits of a branch in a repository.
-func ListRepositories(client *github.Client, t translations.TranslationHelperFunc) (tool mcp.Tool, handler server.ToolHandlerFunc) {
+func ListRepositories(getClient GetClientFn, t translations.TranslationHelperFunc) (tool mcp.Tool, handler server.ToolHandlerFunc) {
 	return mcp.NewTool("list_repositories",
 			mcp.WithDescription(t("TOOL_LIST_REPOSITORIES_DESCRIPTION", "Get list of repositories in a GitHub organization")),
 			mcp.WithString("org",
@@ -70,6 +70,11 @@ func ListRepositories(client *github.Client, t translations.TranslationHelperFun
 				opts.Direction = direction
 			}
 
+			client, err := getClient(ctx)
+			if err != nil {
+				return nil, fmt.Errorf("failed to get GitHub client: %w", err)
+			}
+
 			repos, resp, err := client.Repositories.ListByOrg(ctx, org, opts)
 			if err != nil {
 				return nil, fmt.Errorf("failed to list repositories: %w", err)

pkg/github/organizations_test.go

@@ -16,7 +16,7 @@ import (
 func Test_ListRepositories(t *testing.T) {
 	// Verify tool definition once
 	mockClient := github.NewClient(nil)
-	tool, _ := ListRepositories(mockClient, translations.NullTranslationHelper)
+	tool, _ := ListRepositories(stubGetClientFn(mockClient), translations.NullTranslationHelper)
 
 	assert.Equal(t, "list_repositories", tool.Name)
 	assert.NotEmpty(t, tool.Description)
@@ -172,7 +172,7 @@ func Test_ListRepositories(t *testing.T) {
 		t.Run(tc.name, func(t *testing.T) {
 			// Setup client with mock
 			client := github.NewClient(tc.mockedClient)
-			_, handler := ListRepositories(client, translations.NullTranslationHelper)
+			_, handler := ListRepositories(stubGetClientFn(client), translations.NullTranslationHelper)
 
 			// Create call request
 			request := createMCPRequest(tc.requestArgs)

pkg/github/server.go

@@ -80,7 +80,7 @@ func NewServer(getClient GetClientFn, version string, readOnly bool, t translati
 	}
 
 	// Add GitHub tools - Organizations
-	s.AddTool(ListRepositories(client, t))
+	s.AddTool(ListRepositories(getClient, t))
 
 	// Add GitHub tools - Search
 	s.AddTool(SearchCode(getClient, t))
@@ -181,7 +181,6 @@ func requiredParam[T comparable](r mcp.CallToolRequest, p string) (T, error) {
 
 	if r.Params.Arguments[p].(T) == zero {
 		return zero, fmt.Errorf("missing required parameter: %s", p)
-
 	}
 
 	return r.Params.Arguments[p].(T), nil