Skip to content

Commit 8658c22

Browse files
Fix linting errors in docs.go and docs_test.go
Co-authored-by: colindembovsky <[email protected]>
1 parent 93a13ee commit 8658c22

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

pkg/github/docs.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ func SearchGitHubDocs(t translations.TranslationHelperFunc) (tool mcp.Tool, hand
5656
mcp.Description("Maximum number of results to return (default: 10, max: 100)"),
5757
),
5858
),
59-
func(ctx context.Context, request mcp.CallToolRequest) (*mcp.CallToolResult, error) {
59+
func(_ context.Context, request mcp.CallToolRequest) (*mcp.CallToolResult, error) {
6060
query, err := RequiredParam[string](request, "query")
6161
if err != nil {
6262
return mcp.NewToolResultError(err.Error()), nil
@@ -104,6 +104,7 @@ func SearchGitHubDocs(t translations.TranslationHelperFunc) (tool mcp.Tool, hand
104104
)
105105

106106
// Make the HTTP request
107+
// #nosec G107 - URL is constructed from validated parameters with proper escaping
107108
resp, err := http.Get(searchURL)
108109
if err != nil {
109110
return mcp.NewToolResultError(fmt.Sprintf("failed to search GitHub Docs: %v", err)), nil

pkg/github/docs_test.go

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ func TestSearchGitHubDocs(t *testing.T) {
9090
expectError: false,
9191
},
9292
{
93-
name: "missing required query parameter",
93+
name: "missing required query parameter",
9494
requestArgs: map[string]interface{}{
9595
// no query
9696
},
@@ -124,10 +124,10 @@ func TestSearchGitHubDocs(t *testing.T) {
124124
var handler func(context.Context, mcp.CallToolRequest) (*mcp.CallToolResult, error)
125125

126126
if !tc.expectError || tc.serverStatus != 0 {
127-
mockServer = httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
127+
mockServer = httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
128128
w.Header().Set("Content-Type", "application/json")
129129
w.WriteHeader(tc.serverStatus)
130-
json.NewEncoder(w).Encode(tc.serverResponse)
130+
_ = json.NewEncoder(w).Encode(tc.serverResponse)
131131
}))
132132
defer mockServer.Close()
133133

@@ -189,4 +189,3 @@ func TestDocsSearchResponse(t *testing.T) {
189189
assert.Equal(t, "Test > Article", response.Hits[0].Breadcrumbs)
190190
assert.Equal(t, "Test content", response.Hits[0].Content)
191191
}
192-

0 commit comments

Comments
 (0)