Check if the tool is _NOT_ read only before skipping it in read-only mode (#1514)

omgitsads · web-flow · commit 9b342111e905 · 2025-12-01T16:27:38.000+01:00
diff --git a/pkg/toolsets/toolsets.go b/pkg/toolsets/toolsets.go
@@ -325,7 +325,7 @@ func (tg *ToolsetGroup) RegisterSpecificTools(s *mcp.Server, toolNames []string,
 			return fmt.Errorf("tool %s not found: %w", toolName, err)
 		}
 
-		if tool.Tool.Annotations.ReadOnlyHint && readOnly {
+		if !tool.Tool.Annotations.ReadOnlyHint && readOnly {
 			// Skip write tools in read-only mode
 			skippedTools = append(skippedTools, toolName)
 			continue

Original file line number	Diff line number	Diff line change
`@@ -325,7 +325,7 @@ func (tg ToolsetGroup) RegisterSpecificTools(s mcp.Server, toolNames []string,`
`325`	`325`	`return fmt.Errorf("tool %s not found: %w", toolName, err)`
`326`	`326`	`}`
`327`	`327`
`328`		`- if tool.Tool.Annotations.ReadOnlyHint && readOnly {`
	`328`	`+ if !tool.Tool.Annotations.ReadOnlyHint && readOnly {`
`329`	`329`	`// Skip write tools in read-only mode`
`330`	`330`	`skippedTools = append(skippedTools, toolName)`
`331`	`331`	`continue`