add assertions to e2e tests

Author: SamMorrowDrums

e2e/e2e_test.go

@@ -71,6 +71,7 @@ func getRESTClient(t *testing.T) *gogithub.Client {
 
 	// Create a new GitHub client with the token
 	ghClient := gogithub.NewClient(nil).WithAuthToken(token)
+
 	if host := getE2EHost(); host != "https://github.com" {
 		var err error
 		// Currently this works for GHEC because the API is exposed at the api subdomain and the path prefix
@@ -1600,6 +1601,13 @@ func TestE2E_ManageNotificationSubscription(t *testing.T) {
 	require.True(t, ok)
 	require.Contains(t, textContent.Text, "ignored")
 
+	// Validate with REST client
+	restClient := getRESTClient(t)
+	sub, _, err := restClient.Activity.GetThreadSubscription(ctx, notificationID)
+	require.NoError(t, err)
+	require.NotNil(t, sub)
+	require.True(t, sub.GetIgnored(), "expected notification subscription to be ignored")
+
 	// Watch notification
 	watchReq := mcp.CallToolRequest{}
 	watchReq.Params.Name = "manage_notification_subscription"
@@ -1614,6 +1622,13 @@ func TestE2E_ManageNotificationSubscription(t *testing.T) {
 	require.True(t, ok)
 	require.Contains(t, textContent.Text, "subscribed")
 
+	// Validate with REST client
+	sub, _, err = restClient.Activity.GetThreadSubscription(ctx, notificationID)
+	require.NoError(t, err)
+	require.NotNil(t, sub)
+	require.False(t, sub.GetIgnored(), "expected notification subscription to not be ignored (watch)")
+	require.True(t, sub.GetSubscribed(), "expected notification subscription to be subscribed")
+
 	// Delete notification subscription
 	deleteReq := mcp.CallToolRequest{}
 	deleteReq.Params.Name = "manage_notification_subscription"
@@ -1627,6 +1642,13 @@ func TestE2E_ManageNotificationSubscription(t *testing.T) {
 	textContent, ok = resp.Content[0].(mcp.TextContent)
 	require.True(t, ok)
 	require.Contains(t, textContent.Text, "deleted")
+
+	// Validate with REST client
+	sub, resp2, err := restClient.Activity.GetThreadSubscription(ctx, notificationID)
+	// According to GitHub API, a deleted subscription returns 404
+	require.Error(t, err)
+	require.Nil(t, sub)
+	require.Equal(t, 404, resp2.StatusCode)
 }
 
 func TestE2E_ManageRepositoryNotificationSubscription(t *testing.T) {
@@ -1654,6 +1676,13 @@ func TestE2E_ManageRepositoryNotificationSubscription(t *testing.T) {
 	require.True(t, ok)
 	require.Contains(t, textContent.Text, "ignored")
 
+	// Validate with REST client
+	restClient := getRESTClient(t)
+	sub, _, err := restClient.Activity.GetRepositorySubscription(ctx, owner, repo)
+	require.NoError(t, err)
+	require.NotNil(t, sub)
+	require.True(t, sub.GetIgnored(), "expected repository subscription to be ignored")
+
 	// Watch repo notifications
 	watchReq := mcp.CallToolRequest{}
 	watchReq.Params.Name = "manage_repository_notification_subscription"
@@ -1669,6 +1698,13 @@ func TestE2E_ManageRepositoryNotificationSubscription(t *testing.T) {
 	require.True(t, ok)
 	require.Contains(t, textContent.Text, "subscribed")
 
+	// Validate with REST client
+	sub, _, err = restClient.Activity.GetRepositorySubscription(ctx, owner, repo)
+	require.NoError(t, err)
+	require.NotNil(t, sub)
+	require.False(t, sub.GetIgnored(), "expected repository subscription to not be ignored (watch)")
+	require.True(t, sub.GetSubscribed(), "expected repository subscription to be subscribed")
+
 	// Delete repo notification subscription
 	deleteReq := mcp.CallToolRequest{}
 	deleteReq.Params.Name = "manage_repository_notification_subscription"
@@ -1683,6 +1719,13 @@ func TestE2E_ManageRepositoryNotificationSubscription(t *testing.T) {
 	textContent, ok = resp.Content[0].(mcp.TextContent)
 	require.True(t, ok)
 	require.Contains(t, textContent.Text, "deleted")
+
+	// Validate with REST client
+	sub, resp2, err := restClient.Activity.GetRepositorySubscription(ctx, owner, repo)
+	// According to GitHub API, a deleted subscription returns 404
+	require.Error(t, err)
+	require.Nil(t, sub)
+	require.Equal(t, 404, resp2.StatusCode)
 }
 
 func TestE2E_DismissNotification(t *testing.T) {