Skip to content

Commit fd29e10

Browse files
Update test assertions to check for cursor parameter instead of page/perPage
Co-authored-by: SamMorrowDrums <[email protected]>
1 parent d904e07 commit fd29e10

File tree

7 files changed

+16
-33
lines changed

7 files changed

+16
-33
lines changed

pkg/github/actions_test.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -429,8 +429,7 @@ func Test_ListWorkflowRunArtifacts(t *testing.T) {
429429
assert.Contains(t, tool.InputSchema.Properties, "owner")
430430
assert.Contains(t, tool.InputSchema.Properties, "repo")
431431
assert.Contains(t, tool.InputSchema.Properties, "run_id")
432-
assert.Contains(t, tool.InputSchema.Properties, "perPage")
433-
assert.Contains(t, tool.InputSchema.Properties, "page")
432+
assert.Contains(t, tool.InputSchema.Properties, "cursor")
434433
assert.ElementsMatch(t, tool.InputSchema.Required, []string{"owner", "repo", "run_id"})
435434

436435
tests := []struct {

pkg/github/gists_test.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,7 @@ func Test_ListGists(t *testing.T) {
2323
assert.NotEmpty(t, tool.Description)
2424
assert.Contains(t, tool.InputSchema.Properties, "username")
2525
assert.Contains(t, tool.InputSchema.Properties, "since")
26-
assert.Contains(t, tool.InputSchema.Properties, "page")
27-
assert.Contains(t, tool.InputSchema.Properties, "perPage")
26+
assert.Contains(t, tool.InputSchema.Properties, "cursor")
2827
assert.Empty(t, tool.InputSchema.Required)
2928

3029
// Setup mock gists for success case

pkg/github/issues_test.go

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -254,8 +254,7 @@ func Test_SearchIssues(t *testing.T) {
254254
assert.Contains(t, tool.InputSchema.Properties, "repo")
255255
assert.Contains(t, tool.InputSchema.Properties, "sort")
256256
assert.Contains(t, tool.InputSchema.Properties, "order")
257-
assert.Contains(t, tool.InputSchema.Properties, "perPage")
258-
assert.Contains(t, tool.InputSchema.Properties, "page")
257+
assert.Contains(t, tool.InputSchema.Properties, "cursor")
259258
assert.ElementsMatch(t, tool.InputSchema.Required, []string{"query"})
260259

261260
// Setup mock search results
@@ -749,7 +748,6 @@ func Test_ListIssues(t *testing.T) {
749748
assert.Contains(t, tool.InputSchema.Properties, "direction")
750749
assert.Contains(t, tool.InputSchema.Properties, "since")
751750
assert.Contains(t, tool.InputSchema.Properties, "after")
752-
assert.Contains(t, tool.InputSchema.Properties, "perPage")
753751
assert.ElementsMatch(t, tool.InputSchema.Required, []string{"owner", "repo"})
754752

755753
// Mock issues data
@@ -1598,8 +1596,7 @@ func Test_GetIssueComments(t *testing.T) {
15981596
assert.Contains(t, tool.InputSchema.Properties, "owner")
15991597
assert.Contains(t, tool.InputSchema.Properties, "repo")
16001598
assert.Contains(t, tool.InputSchema.Properties, "issue_number")
1601-
assert.Contains(t, tool.InputSchema.Properties, "page")
1602-
assert.Contains(t, tool.InputSchema.Properties, "perPage")
1599+
assert.Contains(t, tool.InputSchema.Properties, "cursor")
16031600
assert.ElementsMatch(t, tool.InputSchema.Required, []string{"method", "owner", "repo", "issue_number"})
16041601

16051602
// Setup mock comments for success case
@@ -2507,8 +2504,7 @@ func Test_GetSubIssues(t *testing.T) {
25072504
assert.Contains(t, tool.InputSchema.Properties, "owner")
25082505
assert.Contains(t, tool.InputSchema.Properties, "repo")
25092506
assert.Contains(t, tool.InputSchema.Properties, "issue_number")
2510-
assert.Contains(t, tool.InputSchema.Properties, "page")
2511-
assert.Contains(t, tool.InputSchema.Properties, "perPage")
2507+
assert.Contains(t, tool.InputSchema.Properties, "cursor")
25122508
assert.ElementsMatch(t, tool.InputSchema.Required, []string{"method", "owner", "repo", "issue_number"})
25132509

25142510
// Setup mock sub-issues for success case

pkg/github/notifications_test.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,7 @@ func Test_ListNotifications(t *testing.T) {
2727
assert.Contains(t, tool.InputSchema.Properties, "before")
2828
assert.Contains(t, tool.InputSchema.Properties, "owner")
2929
assert.Contains(t, tool.InputSchema.Properties, "repo")
30-
assert.Contains(t, tool.InputSchema.Properties, "page")
31-
assert.Contains(t, tool.InputSchema.Properties, "perPage")
30+
assert.Contains(t, tool.InputSchema.Properties, "cursor")
3231
// All fields are optional, so Required should be empty
3332
assert.Empty(t, tool.InputSchema.Required)
3433

pkg/github/pullrequests_test.go

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -590,8 +590,7 @@ func Test_ListPullRequests(t *testing.T) {
590590
assert.Contains(t, tool.InputSchema.Properties, "base")
591591
assert.Contains(t, tool.InputSchema.Properties, "sort")
592592
assert.Contains(t, tool.InputSchema.Properties, "direction")
593-
assert.Contains(t, tool.InputSchema.Properties, "perPage")
594-
assert.Contains(t, tool.InputSchema.Properties, "page")
593+
assert.Contains(t, tool.InputSchema.Properties, "cursor")
595594
assert.ElementsMatch(t, tool.InputSchema.Required, []string{"owner", "repo"})
596595

597596
// Setup mock PRs for success case
@@ -836,8 +835,7 @@ func Test_SearchPullRequests(t *testing.T) {
836835
assert.Contains(t, tool.InputSchema.Properties, "repo")
837836
assert.Contains(t, tool.InputSchema.Properties, "sort")
838837
assert.Contains(t, tool.InputSchema.Properties, "order")
839-
assert.Contains(t, tool.InputSchema.Properties, "perPage")
840-
assert.Contains(t, tool.InputSchema.Properties, "page")
838+
assert.Contains(t, tool.InputSchema.Properties, "cursor")
841839
assert.ElementsMatch(t, tool.InputSchema.Required, []string{"query"})
842840

843841
mockSearchResult := &github.IssuesSearchResult{
@@ -1142,8 +1140,7 @@ func Test_GetPullRequestFiles(t *testing.T) {
11421140
assert.Contains(t, tool.InputSchema.Properties, "owner")
11431141
assert.Contains(t, tool.InputSchema.Properties, "repo")
11441142
assert.Contains(t, tool.InputSchema.Properties, "pullNumber")
1145-
assert.Contains(t, tool.InputSchema.Properties, "page")
1146-
assert.Contains(t, tool.InputSchema.Properties, "perPage")
1143+
assert.Contains(t, tool.InputSchema.Properties, "cursor")
11471144
assert.ElementsMatch(t, tool.InputSchema.Required, []string{"method", "owner", "repo", "pullNumber"})
11481145

11491146
// Setup mock PR files for success case

pkg/github/repositories_test.go

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -765,8 +765,7 @@ func Test_ListCommits(t *testing.T) {
765765
assert.Contains(t, tool.InputSchema.Properties, "repo")
766766
assert.Contains(t, tool.InputSchema.Properties, "sha")
767767
assert.Contains(t, tool.InputSchema.Properties, "author")
768-
assert.Contains(t, tool.InputSchema.Properties, "page")
769-
assert.Contains(t, tool.InputSchema.Properties, "perPage")
768+
assert.Contains(t, tool.InputSchema.Properties, "cursor")
770769
assert.ElementsMatch(t, tool.InputSchema.Required, []string{"owner", "repo"})
771770

772771
// Setup mock commits for success case
@@ -1675,8 +1674,7 @@ func Test_ListBranches(t *testing.T) {
16751674
assert.NotEmpty(t, tool.Description)
16761675
assert.Contains(t, tool.InputSchema.Properties, "owner")
16771676
assert.Contains(t, tool.InputSchema.Properties, "repo")
1678-
assert.Contains(t, tool.InputSchema.Properties, "page")
1679-
assert.Contains(t, tool.InputSchema.Properties, "perPage")
1677+
assert.Contains(t, tool.InputSchema.Properties, "cursor")
16801678
assert.ElementsMatch(t, tool.InputSchema.Required, []string{"owner", "repo"})
16811679

16821680
// Setup mock branches for success case
@@ -2923,8 +2921,7 @@ func Test_ListStarredRepositories(t *testing.T) {
29232921
assert.Contains(t, tool.InputSchema.Properties, "username")
29242922
assert.Contains(t, tool.InputSchema.Properties, "sort")
29252923
assert.Contains(t, tool.InputSchema.Properties, "direction")
2926-
assert.Contains(t, tool.InputSchema.Properties, "page")
2927-
assert.Contains(t, tool.InputSchema.Properties, "perPage")
2924+
assert.Contains(t, tool.InputSchema.Properties, "cursor")
29282925
assert.Empty(t, tool.InputSchema.Required) // All parameters are optional
29292926

29302927
// Setup mock starred repositories

pkg/github/search_test.go

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,7 @@ func Test_SearchRepositories(t *testing.T) {
2525
assert.Contains(t, tool.InputSchema.Properties, "query")
2626
assert.Contains(t, tool.InputSchema.Properties, "sort")
2727
assert.Contains(t, tool.InputSchema.Properties, "order")
28-
assert.Contains(t, tool.InputSchema.Properties, "page")
29-
assert.Contains(t, tool.InputSchema.Properties, "perPage")
28+
assert.Contains(t, tool.InputSchema.Properties, "cursor")
3029
assert.ElementsMatch(t, tool.InputSchema.Required, []string{"query"})
3130

3231
// Setup mock search results
@@ -239,8 +238,7 @@ func Test_SearchCode(t *testing.T) {
239238
assert.Contains(t, tool.InputSchema.Properties, "query")
240239
assert.Contains(t, tool.InputSchema.Properties, "sort")
241240
assert.Contains(t, tool.InputSchema.Properties, "order")
242-
assert.Contains(t, tool.InputSchema.Properties, "perPage")
243-
assert.Contains(t, tool.InputSchema.Properties, "page")
241+
assert.Contains(t, tool.InputSchema.Properties, "cursor")
244242
assert.ElementsMatch(t, tool.InputSchema.Required, []string{"query"})
245243

246244
// Setup mock search results
@@ -394,8 +392,7 @@ func Test_SearchUsers(t *testing.T) {
394392
assert.Contains(t, tool.InputSchema.Properties, "query")
395393
assert.Contains(t, tool.InputSchema.Properties, "sort")
396394
assert.Contains(t, tool.InputSchema.Properties, "order")
397-
assert.Contains(t, tool.InputSchema.Properties, "perPage")
398-
assert.Contains(t, tool.InputSchema.Properties, "page")
395+
assert.Contains(t, tool.InputSchema.Properties, "cursor")
399396
assert.ElementsMatch(t, tool.InputSchema.Required, []string{"query"})
400397

401398
// Setup mock search results
@@ -588,8 +585,7 @@ func Test_SearchOrgs(t *testing.T) {
588585
assert.Contains(t, tool.InputSchema.Properties, "query")
589586
assert.Contains(t, tool.InputSchema.Properties, "sort")
590587
assert.Contains(t, tool.InputSchema.Properties, "order")
591-
assert.Contains(t, tool.InputSchema.Properties, "perPage")
592-
assert.Contains(t, tool.InputSchema.Properties, "page")
588+
assert.Contains(t, tool.InputSchema.Properties, "cursor")
593589
assert.ElementsMatch(t, tool.InputSchema.Required, []string{"query"})
594590

595591
// Setup mock search results

0 commit comments

Comments
 (0)