Initialize lockdown cache singleton once per test function

[Copilot]

Closes: #issue

Description

Tests calling stubRepoAccessCache() created separate singleton instances due to sync.Once semantics—first initialization won, subsequent calls with different mock clients were ignored. This caused test failures when subtests needed specific GraphQL mock behavior.

Changes

pkg/lockdown/lockdown.go

• Added ResetInstance() to clear singleton state between tests

Test files (pkg/github/issues_test.go, pkg/github/pullrequests_test.go, pkg/lockdown/lockdown_test.go)

• Initialize cache once at test function start via ResetInstance() + GetInstance()
• Subtests conditionally reset when requiring custom mock clients
• 11 test functions updated across 3 files

Example

func Test_GetIssue(t *testing.T) {
    // Initialize once for all subtests
    gqlClient := githubv4.NewClient(nil)
    lockdown.ResetInstance()
    lockdown.GetInstance(gqlClient, lockdown.WithTTL(5*time.Minute))
    
    // Subtests share the same cache instance
    for _, tc := range tests {
        t.Run(tc.name, func(t *testing.T) {
            if tc.gqlHTTPClient != nil {
                // Reset only when custom mock needed
                lockdown.ResetInstance()
                gqlClient = githubv4.NewClient(tc.gqlHTTPClient)
            }
            // ...
        })
    }
}

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• https://api.github.com/graphql
  • Triggering command: /tmp/go-build1162513046/b001/github.test -test.testlogfile=/tmp/go-build1162513046/b001/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true -test.run=Test_GetIssue (http block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Original prompt

Update all tests using lockdown cache and make them initialize cache only once instead of separately for each test.

The user has attached the following file paths as relevant context:

• .github/copilot-instructions.md

Created from VS Code via the GitHub Pull Request extension.

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[stasyu2009-ux]

Код потрібно вставити готовий
і все

[stasyu2009-ux]

func Test_GetIssue(t testing.T) {
// Initialize once for all subtests
gqlClient := githubv4.NewClient(nil)
lockdown.ResetInstance()
lockdown.GetInstance(gqlClient, lockdown.WithTTL(5time.Minute))

// Subtests share the same cache instance
for _, tc := range tests {
    t.Run(tc.name, func(t *testing.T) {
        if tc.gqlHTTPClient != nil {
            // Reset only when custom mock needed
            lockdown.ResetInstance()
            gqlClient = githubv4.NewClient(tc.gqlHTTPClient)
        }
        // ...
    })
}

}

[stasyu2009-ux]

import memoize from '@github/memoize'
import {getEnv} from '@github-ui/client-env'
import {IS_SERVER} from '@github-ui/ssr-utils'
import type {JSFeatureFlag} from './client-feature-flags'

function getEnabledFeaturesSet() {
return new Set(getEnv().featureFlags as JSFeatureFlag[])
}

const featuresSet =
IS_SERVER || process.env.NODE_ENV === 'test' || isStorybook() ? getEnabledFeaturesSet : memoize(getEnabledFeaturesSet)

export function getEnabledFeatures(): JSFeatureFlag[] {
return Array.from(featuresSet())
}

/**

• This function accesses feature flag states which have been loaded into the client env via the client-feature-flags.ts file.
• See https://thehub.github.com/epd/engineering/products-and-services/dotcom/features/feature-flags/typescript-frontend
• for more details.
• If you're trying to check a feature flag that was added to the enabled_features of a React payload via add_client_feature_flag in a
• Rails controller, you should use the useFeatureFlag hook (from @github-ui/react-core/use-feature-flag) instead to access the feature flag state.
• https://thehub.github.com/epd/engineering/products-and-services/dotcom/features/feature-flags/typescript-frontend has
• more information on useFeatureFlag and add_client_feature_flag.
  */
  export function isFeatureEnabled(name: JSFeatureFlag): boolean {
  return featuresSet().has(name)
  }

// exported to allow mocking in tests
const featureFlag = {isFeatureEnabled}

export {featureFlag}

function isStorybook() {
try {
return process?.env?.STORYBOOK === 'true' || process?.env?.APP_ENV === 'storybook'
} catch {
return false
}
}
This code is done incorrectly and I can't edit this code. You need to fix the error here and everything will work correctly.