Fix tools read write consolidated #994
Conversation
…ers (#1) * Initial plan * Initial analysis and planning for CRUD tool consolidation Co-authored-by: mattdholloway <[email protected]> * Implement consolidated manage_gist tool with CRUD operations Co-authored-by: mattdholloway <[email protected]> * Complete phases 2-3: Consolidated code scanning and secret scanning alert tools Co-authored-by: mattdholloway <[email protected]> * Consolidate issue, pull request, and repository operations with manage_* tools Co-authored-by: mattdholloway <[email protected]> * Remove old individual tools replaced by consolidated manage_* tools Co-authored-by: mattdholloway <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: mattdholloway <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR consolidates several GitHub tool operations into unified management tools to reduce API surface area and improve usability. The changes replace multiple specific-purpose tools with consolidated "manage" tools that accept an operation parameter to determine the action to perform.
- Consolidates repository, issue, pull request, gist, and security scanning tools into unified management interfaces
- Reduces the number of individual tools from ~30 to ~5 consolidated tools
- Updates documentation to reflect the new consolidated tool structure
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/github/tools.go | Updates tool registration to use new consolidated tools instead of individual tools |
| pkg/github/repositories.go | Adds ManageRepository tool consolidating create, fork, and get_file_contents operations |
| pkg/github/issues.go | Adds ManageIssue tool consolidating list, get, create, update, and add_comment operations |
| pkg/github/pullrequests.go | Adds ManagePullRequest tool consolidating list, get, create, update, and merge operations |
| pkg/github/gists.go | Adds ManageGist tool consolidating list, create, update, and get operations |
| pkg/github/code_scanning.go | Adds ManageCodeScanningAlerts tool consolidating list and get operations |
| pkg/github/secret_scanning.go | Adds ManageSecretScanningAlerts tool consolidating list and get operations |
| Test files | Adds tests for the new consolidated management tools |
| README.md | Updates documentation to reflect the consolidated tool structure |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| func Test_ManageSecretScanningAlerts(t *testing.T) { | ||
| // Verify tool definition | ||
| mockClient := github.NewClient(nil) |
There was a problem hiding this comment.
Missing blank line after function declaration. Add a blank line between the function signature and the first comment.
| func Test_ManageGist(t *testing.T) { | ||
| // Verify tool definition | ||
| mockClient := github.NewClient(nil) |
There was a problem hiding this comment.
Missing blank line after function declaration. Add a blank line between the function signature and the first comment.
| func Test_ManageCodeScanningAlerts(t *testing.T) { | ||
| // Verify tool definition | ||
| mockClient := github.NewClient(nil) |
There was a problem hiding this comment.
Missing blank line after function declaration. Add a blank line between the function signature and the first comment.
1 participant
Closes: