Skip to content

Commit 214e99a

Browse files
committed
refactor: rename variable for clarity in shared secret validation
1 parent 5fb81ad commit 214e99a

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

lib/hooks/plugins/auth/shared_secret.rb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -68,21 +68,21 @@ def self.valid?(payload:, headers:, config:)
6868
secret_header = validator_config[:header]
6969

7070
# Find the secret header with case-insensitive matching
71-
raw_secret = find_header_value(headers, secret_header)
71+
provided_secret = find_header_value(headers, secret_header)
7272

73-
if raw_secret.nil? || raw_secret.empty?
73+
if provided_secret.nil? || provided_secret.empty?
7474
log.warn("Auth::SharedSecret validation failed: Missing or empty secret header '#{secret_header}'")
7575
return false
7676
end
7777

7878
# Validate secret format using shared validation
79-
unless valid_header_value?(raw_secret, "Secret")
79+
unless valid_header_value?(provided_secret, "Secret")
8080
log.warn("Auth::SharedSecret validation failed: Invalid secret format")
8181
return false
8282
end
8383

8484
# Use secure comparison to prevent timing attacks
85-
result = Rack::Utils.secure_compare(secret, raw_secret)
85+
result = Rack::Utils.secure_compare(secret, provided_secret)
8686
if result
8787
log.debug("Auth::SharedSecret validation successful for header '#{secret_header}'")
8888
else

0 commit comments

Comments
 (0)