Make log_level, root_path, and environment required fields in global configuration schema

Author: GrantBirki

lib/hooks/core/config_validator.rb

@@ -16,13 +16,13 @@ class ValidationError < StandardError; end
         optional(:auth_plugin_dir).maybe(:string)
         optional(:lifecycle_plugin_dir).maybe(:string)
         optional(:instruments_plugin_dir).maybe(:string)
-        optional(:log_level).filled(:string, included_in?: %w[debug info warn error])
+        required(:log_level).filled(:string, included_in?: %w[debug info warn error])
         optional(:request_limit).filled(:integer, gt?: 0)
         optional(:request_timeout).filled(:integer, gt?: 0)
-        optional(:root_path).filled(:string)
+        required(:root_path).filled(:string)
         optional(:health_path).filled(:string)
         optional(:version_path).filled(:string)
-        optional(:environment).filled(:string, included_in?: %w[development production])
+        required(:environment).filled(:string, included_in?: %w[development production])
         optional(:endpoints_dir).filled(:string)
         optional(:use_catchall_route).filled(:bool)
         optional(:normalize_headers).filled(:bool)

spec/unit/lib/hooks/core/config_validator_spec.rb

@@ -24,17 +24,24 @@
       end
 
       it "returns validated configuration with minimal fields" do
-        config = { handler_plugin_dir: "/path/to/handlers" }
+        config = {
+          handler_plugin_dir: "/path/to/handlers",
+          log_level: "info",
+          root_path: "/app",
+          environment: "development"
+        }
 
         result = described_class.validate_global_config(config)
 
-        expect(result).to eq({ handler_plugin_dir: "/path/to/handlers" })
+        expect(result).to eq(config)
       end
 
       it "accepts production environment" do
         config = {
           environment: "production",
-          handler_plugin_dir: "/path/to/handlers"
+          handler_plugin_dir: "/path/to/handlers",
+          log_level: "info",
+          root_path: "/app"
         }
 
         result = described_class.validate_global_config(config)
@@ -46,7 +53,9 @@
         %w[debug info warn error].each do |log_level|
           config = {
             log_level: log_level,
-            handler_plugin_dir: "/path/to/handlers"
+            handler_plugin_dir: "/path/to/handlers",
+            root_path: "/app",
+            environment: "development"
           }
 
           result = described_class.validate_global_config(config)
@@ -121,7 +130,10 @@
         config = {
           use_catchall_route: "true",
           normalize_headers: "1",
-          handler_plugin_dir: "/path/to/handlers"
+          handler_plugin_dir: "/path/to/handlers",
+          log_level: "info",
+          root_path: "/app",
+          environment: "development"
         }
 
         result = described_class.validate_global_config(config)
@@ -146,7 +158,10 @@
         config = {
           request_limit: "1024",
           request_timeout: "30",
-          handler_plugin_dir: "/path/to/handlers"
+          handler_plugin_dir: "/path/to/handlers",
+          log_level: "info",
+          root_path: "/app",
+          environment: "development"
         }
 
         result = described_class.validate_global_config(config)
@@ -174,7 +189,10 @@
       it "coerces float values to integers by truncating" do
         config = {
           request_timeout: 30.5,
-          handler_plugin_dir: "/path/to/handlers"
+          handler_plugin_dir: "/path/to/handlers",
+          log_level: "info",
+          root_path: "/app",
+          environment: "development"
         }
 
         result = described_class.validate_global_config(config)