Rename start_time to server_start_time for clarity and update related references

Author: GrantBirki

lib/hooks/app/api.rb

@@ -21,12 +21,12 @@ class API
       include Hooks::App::Auth
 
       class << self
-        attr_reader :start_time
+        attr_reader :server_start_time
       end
 
       # Create a new configured API class
       def self.create(config:, endpoints:, log:)
-        @start_time = Time.now
+        @server_start_time = Time.now
 
         Hooks::Log.instance = log
 

lib/hooks/app/endpoints/health.rb

@@ -12,7 +12,7 @@ class HealthEndpoint < Grape::API
           status: "healthy",
           timestamp: Time.now.iso8601,
           version: Hooks::VERSION,
-          uptime_seconds: (Time.now - Hooks::App::API.start_time).to_i
+          uptime_seconds: (Time.now - Hooks::App::API.server_start_time).to_i
         }.to_json
       end
     end

spec/unit/lib/hooks/app/endpoints/health_spec.rb

@@ -10,8 +10,8 @@ def app
   end
 
   before do
-    # Mock API start_time for consistent uptime calculation
-    allow(Hooks::App::API).to receive(:start_time).and_return(Time.parse("2024-12-31T23:59:00Z"))
+    # Mock API server_start_time for consistent uptime calculation
+    allow(Hooks::App::API).to receive(:server_start_time).and_return(Time.parse("2024-12-31T23:59:00Z"))
   end
 
   describe "GET /" do
@@ -66,7 +66,7 @@ def app
     it "calculates uptime correctly" do
       # Test with different start time
       different_start = Time.parse("2024-12-31T23:58:30Z")
-      allow(Hooks::App::API).to receive(:start_time).and_return(different_start)
+      allow(Hooks::App::API).to receive(:server_start_time).and_return(different_start)
 
       get "/"