cleanup

Author: GrantBirki

.rubocop.yml

@@ -16,5 +16,9 @@ GitHub/InsecureHashAlgorithm:
   Exclude:
     - "spec/unit/lib/hooks/plugins/request_validator/hmac_spec.rb"
 
+GitHub/AvoidObjectSendWithDynamicMethod:
+  Exclude:
+    - "spec/unit/lib/hooks/core/logger_factory_spec.rb"
+
 Style/HashSyntax:
   Enabled: false

spec/unit/lib/hooks/core/builder_spec.rb

@@ -1,8 +1,5 @@
 # frozen_string_literal: true
 
-require_relative "../../../spec_helper"
-require "fileutils"
-
 describe Hooks::Core::Builder do
   let(:temp_dir) { "/tmp/hooks_builder_test" }
 
@@ -87,9 +84,7 @@
       end
 
       it "loads endpoints from the endpoints directory" do
-        config = { log_level: "info", environment: "test", endpoints_dir: "/nonexistent" }
         expect(Hooks::Core::ConfigLoader).to receive(:load_endpoints).with("/nonexistent")
-
         builder.build
       end
 

spec/unit/lib/hooks/core/config_loader_spec.rb

@@ -1,8 +1,5 @@
 # frozen_string_literal: true
 
-require_relative "../../../spec_helper"
-require "fileutils"
-
 describe Hooks::Core::ConfigLoader do
   describe ".load" do
     context "with no config_path provided" do

spec/unit/lib/hooks/core/config_validator_spec.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require_relative "../../../spec_helper"
-
 describe Hooks::Core::ConfigValidator do
   describe ".validate_global_config" do
     context "with valid configuration" do

spec/unit/lib/hooks/core/logger_factory_spec.rb

@@ -1,8 +1,5 @@
 # frozen_string_literal: true
 
-require_relative "../../../spec_helper"
-require "stringio"
-
 describe Hooks::Core::LoggerFactory do
   describe ".create" do
     context "with default parameters" do

spec/unit/lib/hooks/core/signal_handler_spec.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require_relative "../../../spec_helper"
-
 describe Hooks::Core::SignalHandler do
   let(:logger) { double("Logger", info: nil) }
 

spec/unit/lib/hooks/handlers/base_spec.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require_relative "../../../spec_helper"
-
 describe Hooks::Handlers::Base do
   describe "#call" do
     let(:handler) { described_class.new }

spec/unit/lib/hooks/plugins/lifecycle_spec.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require_relative "../../../spec_helper"
-
 describe Hooks::Plugins::Lifecycle do
   let(:plugin) { described_class.new }
   let(:env) { { "REQUEST_METHOD" => "POST", "PATH_INFO" => "/webhook" } }

spec/unit/lib/hooks/plugins/request_validator/base_spec.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require_relative "../../../../spec_helper"
-
 describe Hooks::Plugins::RequestValidator::Base do
   describe ".valid?" do
     let(:payload) { '{"test": "data"}' }