make the message more clear when no auth_plugin_dir is set for the given auth_type

Author: GrantBirki

lib/hooks/app/auth/auth.rb

@@ -52,7 +52,7 @@ def validate_auth!(payload, headers, endpoint_config, global_config = {})
               error!("failed to load custom auth plugin '#{auth_type}': #{e.message}", 500)
             end
           else
-            error!("Custom validators not implemented in POC", 500)
+            error!("unsupported auth type '#{auth_type}' due to auth_plugin_dir not being set", 400)
           end
         end
 

spec/unit/lib/hooks/app/auth/auth_security_spec.rb

@@ -215,7 +215,7 @@ def error!(message, code)
 
           expect do
             instance.validate_auth!(payload, headers, endpoint_config)
-          end.to raise_error(StandardError, /Custom validators not implemented/)
+          end.to raise_error(StandardError, /unsupported auth type/)
         end
       end
     end

spec/unit/lib/hooks/app/auth/custom_auth_plugin_spec.rb

@@ -44,7 +44,7 @@ def error!(message, code)
 
         expect do
           instance.validate_auth!(payload, headers, endpoint_config, empty_global_config)
-        end.to raise_error(StandardError, /Custom validators not implemented in POC/)
+        end.to raise_error(StandardError, /unsupported auth type/)
       end
     end