Skip to content

Commit a987f81

Browse files
zkoppertjmeridth
andauthored
chore: readable and pythonic logic
Co-authored-by: jmeridth <[email protected]>
1 parent 5e6d889 commit a987f81

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

issue_metrics.py

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -193,10 +193,10 @@ def get_per_issue_metrics(
193193
)
194194
if env_vars.hide_time_to_answer is False:
195195
issue_with_metrics.time_to_answer = measure_time_to_answer(issue)
196-
if env_vars.hide_time_to_close is False and issue["closedAt"]:
197-
issue_with_metrics.time_to_close = measure_time_to_close(None, issue)
198196
if issue["closedAt"]:
199197
num_issues_closed += 1
198+
if not env_vars.hide_time_to_close:
199+
issue_with_metrics.time_to_close = measure_time_to_close(None, issue)
200200
else:
201201
num_issues_open += 1
202202
else:
@@ -234,17 +234,17 @@ def get_per_issue_metrics(
234234
)
235235
if labels and env_vars.hide_label_metrics is False:
236236
issue_with_metrics.label_metrics = get_label_metrics(issue, labels)
237-
if env_vars.hide_time_to_close is False and issue.state == "closed": # type: ignore
238-
if pull_request:
239-
issue_with_metrics.time_to_close = measure_time_to_merge(
240-
pull_request, ready_for_review_at
241-
)
242-
else:
243-
issue_with_metrics.time_to_close = measure_time_to_close(
244-
issue, None
245-
)
246237
if issue.state == "closed": # type: ignore
247238
num_issues_closed += 1
239+
if not env_vars.hide_time_to_close:
240+
if pull_request:
241+
issue_with_metrics.time_to_close = measure_time_to_merge(
242+
pull_request, ready_for_review_at
243+
)
244+
else:
245+
issue_with_metrics.time_to_close = measure_time_to_close(
246+
issue, None
247+
)
248248
elif issue.state == "open": # type: ignore
249249
num_issues_open += 1
250250
issues_with_metrics.append(issue_with_metrics)

0 commit comments

Comments
 (0)