refactor: move needless if condition out of loop

keithamus · keithamus · commit 7fef62f7e56d · 2020-03-19T12:31:49.000Z
diff --git a/index.js b/index.js
@@ -290,10 +290,9 @@ function focusKeydown(event: KeyboardEvent) {
 
   for (let i = 0; i < length; i += 1) {
     buttons[i].setAttribute('tabindex', i === n ? '0' : '-1')
-    if (i === n) {
-      buttons[i].focus()
-    }
   }
+
+  buttons[n].focus()
 }
 
 const shortcutListeners = new WeakMap()

Original file line number	Diff line number	Diff line change
`@@ -290,10 +290,9 @@ function focusKeydown(event: KeyboardEvent) {`
`290`	`290`
`291`	`291`	`for (let i = 0; i < length; i += 1) {`
`292`	`292`	`buttons[i].setAttribute('tabindex', i === n ? '0' : '-1')`
`293`		`- if (i === n) {`
`294`		`- buttons[i].focus()`
`295`		`- }`
`296`	`293`	`}`
	`294`	`+`
	`295`	`+ buttons[n].focus()`
`297`	`296`	`}`
`298`	`297`
`299`	`298`	`const shortcutListeners = new WeakMap()`