Skip to content

Commit b395a41

Browse files
committed
Change constructors to connectedCallbacks
Since `constructor` can be error-prone for custom elements and keep all the components similar, I've also changed all the constructors to `connectedCallback` functions.
1 parent 8c211d4 commit b395a41

File tree

1 file changed

+12
-24
lines changed

1 file changed

+12
-24
lines changed

src/index.ts

Lines changed: 12 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -130,8 +130,7 @@ if (!window.customElements.get('md-header')) {
130130
}
131131

132132
class MarkdownBoldButtonElement extends MarkdownButtonElement {
133-
constructor() {
134-
super()
133+
connectedCallback() {
135134
styles.set(this, {prefix: '**', suffix: '**', trimFirst: true})
136135
}
137136
}
@@ -142,8 +141,7 @@ if (!window.customElements.get('md-bold')) {
142141
}
143142

144143
class MarkdownItalicButtonElement extends MarkdownButtonElement {
145-
constructor() {
146-
super()
144+
connectedCallback() {
147145
styles.set(this, {prefix: '_', suffix: '_', trimFirst: true})
148146
}
149147
}
@@ -154,8 +152,7 @@ if (!window.customElements.get('md-italic')) {
154152
}
155153

156154
class MarkdownQuoteButtonElement extends MarkdownButtonElement {
157-
constructor() {
158-
super()
155+
connectedCallback() {
159156
styles.set(this, {prefix: '> ', multiline: true, surroundWithNewlines: true})
160157
}
161158
}
@@ -166,8 +163,7 @@ if (!window.customElements.get('md-quote')) {
166163
}
167164

168165
class MarkdownCodeButtonElement extends MarkdownButtonElement {
169-
constructor() {
170-
super()
166+
connectedCallback() {
171167
styles.set(this, {prefix: '`', suffix: '`', blockPrefix: '```', blockSuffix: '```'})
172168
}
173169
}
@@ -178,8 +174,7 @@ if (!window.customElements.get('md-code')) {
178174
}
179175

180176
class MarkdownLinkButtonElement extends MarkdownButtonElement {
181-
constructor() {
182-
super()
177+
connectedCallback() {
183178
styles.set(this, {prefix: '[', suffix: '](url)', replaceNext: 'url', scanFor: 'https?://'})
184179
}
185180
}
@@ -190,8 +185,7 @@ if (!window.customElements.get('md-link')) {
190185
}
191186

192187
class MarkdownImageButtonElement extends MarkdownButtonElement {
193-
constructor() {
194-
super()
188+
connectedCallback() {
195189
styles.set(this, {prefix: '![', suffix: '](url)', replaceNext: 'url', scanFor: 'https?://'})
196190
}
197191
}
@@ -202,8 +196,7 @@ if (!window.customElements.get('md-image')) {
202196
}
203197

204198
class MarkdownUnorderedListButtonElement extends MarkdownButtonElement {
205-
constructor() {
206-
super()
199+
connectedCallback() {
207200
styles.set(this, {prefix: '- ', multiline: true, unorderedList: true})
208201
}
209202
}
@@ -214,8 +207,7 @@ if (!window.customElements.get('md-unordered-list')) {
214207
}
215208

216209
class MarkdownOrderedListButtonElement extends MarkdownButtonElement {
217-
constructor() {
218-
super()
210+
connectedCallback() {
219211
styles.set(this, {prefix: '1. ', multiline: true, orderedList: true})
220212
}
221213
}
@@ -226,8 +218,7 @@ if (!window.customElements.get('md-ordered-list')) {
226218
}
227219

228220
class MarkdownTaskListButtonElement extends MarkdownButtonElement {
229-
constructor() {
230-
super()
221+
connectedCallback() {
231222
styles.set(this, {prefix: '- [ ] ', multiline: true, surroundWithNewlines: true})
232223
}
233224
}
@@ -238,8 +229,7 @@ if (!window.customElements.get('md-task-list')) {
238229
}
239230

240231
class MarkdownMentionButtonElement extends MarkdownButtonElement {
241-
constructor() {
242-
super()
232+
connectedCallback() {
243233
styles.set(this, {prefix: '@', prefixSpace: true})
244234
}
245235
}
@@ -250,8 +240,7 @@ if (!window.customElements.get('md-mention')) {
250240
}
251241

252242
class MarkdownRefButtonElement extends MarkdownButtonElement {
253-
constructor() {
254-
super()
243+
connectedCallback() {
255244
styles.set(this, {prefix: '#', prefixSpace: true})
256245
}
257246
}
@@ -262,8 +251,7 @@ if (!window.customElements.get('md-ref')) {
262251
}
263252

264253
class MarkdownStrikethroughButtonElement extends MarkdownButtonElement {
265-
constructor() {
266-
super()
254+
connectedCallback() {
267255
styles.set(this, {prefix: '~~', suffix: '~~', trimFirst: true})
268256
}
269257
}

0 commit comments

Comments
 (0)