Skip to content

Commit bfde860

Browse files
author
Paul Dixon
committed
use data attribute instead of non standard attribute, and dont set the data if not present
1 parent 347bec1 commit bfde860

File tree

2 files changed

+3
-7
lines changed

2 files changed

+3
-7
lines changed

index.js

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,11 +44,7 @@ class MarkdownHeaderButtonElement extends MarkdownButtonElement {
4444
constructor() {
4545
super()
4646

47-
if (!this.hasAttribute('level')) {
48-
this.setAttribute('level', '3')
49-
}
50-
51-
const level = parseInt(this.getAttribute('level'), 10)
47+
const level = parseInt(this.dataset.level || 3, 10)
5248
const prefix = `${'#'.repeat(level)} `
5349
styles.set(this, {
5450
prefix

test/test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ describe('markdown-toolbbar-element', function() {
7070
<markdown-toolbar for="textarea_id">
7171
<md-bold>bold</md-bold>
7272
<md-header>header</md-header>
73-
<md-header level="1">h1</md-header>
73+
<md-header data-level="1">h1</md-header>
7474
<md-italic>italic</md-italic>
7575
<md-quote>quote</md-quote>
7676
<md-code>code</md-code>
@@ -499,7 +499,7 @@ describe('markdown-toolbbar-element', function() {
499499
})
500500
it('inserts header 1 syntax with cursor in description', function() {
501501
setVisualValue('|title|')
502-
clickToolbar('md-header[level="1"]')
502+
clickToolbar('md-header[data-level="1"]')
503503
assert.equal('# |title|', visualValue())
504504
})
505505
})

0 commit comments

Comments
 (0)