Fix missing trailing .js and following tests

Author: JoyceZhu

.markdownlint-cli2.mjs

@@ -8,7 +8,6 @@ const configOptions = await init({
   "no-emphasis-as-heading": true,
   "first-line-heading": true,
 });
-console.log(configOptions);
 const options = {
   config: configOptions,
   customRules: ["./index.js"],

index.js

@@ -1,25 +1,25 @@
 import { readFile } from "fs/promises";
 import _ from "lodash-es";
-// import githubMarkdownLint from "./src/rules/index.js";
+import { githubMarkdownLint } from "./src/rules/index.js";
 
 const offByDefault = ["no-empty-alt-text"];
-// const foo = [altTextRule, noGenericLinkTextRule, noEmptyStringAltRule];
-// for (const rule of foo) {
-//   const ruleName = rule.names[1];
-//   base[ruleName] = offByDefault.includes(ruleName) ? false : true;
-// }
 
 export async function init(consumerConfig) {
   // left overwrites right
   const accessibilityRules = JSON.parse(
-    await readFile(new URL("./style/accessibility.json", import.meta.url))
+    await readFile(new URL("./style/accessibility.json", import.meta.url)),
   );
 
   const base = JSON.parse(
-    await readFile(new URL("./style/base.json", import.meta.url))
+    await readFile(new URL("./style/base.json", import.meta.url)),
   );
 
+  for (const rule of githubMarkdownLint) {
+    const ruleName = rule.names[1];
+    base[ruleName] = offByDefault.includes(ruleName) ? false : true;
+  }
+
   return _.defaultsDeep(consumerConfig, accessibilityRules, base);
 }
 
-// export { default } from "./rules";
+export default githubMarkdownLint;

src/rules/index.js

@@ -2,4 +2,10 @@ import { noEmptyStringAltRule } from "./no-empty-alt-text.js";
 import { noGenericLinkTextRule } from "./no-generic-link-text.js";
 import { altTextRule } from "./no-default-alt-text.js";
 
-export default { noEmptyStringAltRule, noGenericLinkTextRule, altTextRule };
+// export default { noEmptyStringAltRule, noGenericLinkTextRule, altTextRule };
+
+export const githubMarkdownLint = [
+  altTextRule,
+  noGenericLinkTextRule,
+  noEmptyStringAltRule,
+];

src/rules/no-generic-link-text.js

@@ -1,4 +1,4 @@
-import { stripAndDowncaseText } from "../helpers/strip-and-downcase-text";
+import { stripAndDowncaseText } from "../helpers/strip-and-downcase-text.js";
 
 const bannedLinkText = [
   "read more",

test/accessibility-rules.test.js

@@ -1,5 +1,4 @@
 import { lint } from "markdownlint/async";
-// import * as accessibilityRulesConfig from "../style/accessibility.json";
 import { githubMarkdownLint } from "../src/rules";
 
 const exampleFileName = "./test/example.md";
@@ -28,8 +27,6 @@ const options = {
   customRules: githubMarkdownLint,
 };
 
-console.log(options);
-
 describe("when A11y rules applied", () => {
   test("fails expected rules", async () => {
     const result = await new Promise((resolve, reject) => {

test/usage.test.js

@@ -5,7 +5,6 @@ describe("usage", () => {
   describe("default export", () => {
     test("custom rules on default export", () => {
       const rules = githubMarkdownLint;
-      console.log(rules);
       expect(rules).toHaveLength(3);
 
       expect(rules[0].names).toEqual(["GH001", "no-default-alt-text"]);
@@ -14,8 +13,8 @@ describe("usage", () => {
     });
   });
   describe("init method", () => {
-    test("default options returned with no arguments provided", () => {
-      const options = init();
+    test("default options returned with no arguments provided", async () => {
+      const options = await init();
       expect(options).toEqual({
         "no-duplicate-heading": true,
         "ol-prefix": "ordered",
@@ -38,8 +37,8 @@ describe("usage", () => {
       });
     });
 
-    test("arguments override default configuration", () => {
-      const defaultOptions = init();
+    test("arguments override default configuration", async () => {
+      const defaultOptions = await init();
 
       const toTestOptions = Object.keys(defaultOptions).slice(0, 3);
 
@@ -54,20 +53,20 @@ describe("usage", () => {
       expect(originalConfig).not.toEqual(consumerConfig);
 
       // do config step
-      const options = init(consumerConfig);
+      const options = await init(consumerConfig);
 
       // confirm config is set by consumer
       expect(options).toHaveProperty(
         toTestOptions[0],
-        consumerConfig[toTestOptions[0]]
+        consumerConfig[toTestOptions[0]],
       );
       expect(options).toHaveProperty(
         toTestOptions[1],
-        consumerConfig[toTestOptions[1]]
+        consumerConfig[toTestOptions[1]],
       );
       expect(options).toHaveProperty(
         toTestOptions[2],
-        consumerConfig[toTestOptions[2]]
+        consumerConfig[toTestOptions[2]],
       );
     });
   });