fix: ensure innersource_report.md is consistently used and tested

Signed-off-by: Zack Koppert <zkoppert@github.com>

Author: zkoppert

config.py

@@ -154,7 +154,9 @@ def get_env_vars(test: bool = False) -> EnvVars:
     owner, repo = repository.split("/", 1)
 
     report_title = os.getenv("REPORT_TITLE", "InnerSource Report")
-    output_file = os.getenv("OUTPUT_FILE", "InnerSource_Report.md")
+    output_file = os.getenv("OUTPUT_FILE")
+    if not output_file:
+        output_file = "innersource_report.md"
     rate_limit_bypass = get_bool_env_var("RATE_LIMIT_BYPASS", False)
 
     return EnvVars(

test_config.py

@@ -105,7 +105,7 @@ def test_get_env_vars_with_github_app(self):
             report_title="",
             owner="test_owner",
             repo="test_repo",
-            output_file="",
+            output_file="innersource_report.md",
         )
         result = get_env_vars(True)
         self.assertEqual(str(result), str(expected_result))
@@ -136,7 +136,7 @@ def test_get_env_vars_with_token(self):
             report_title="",
             owner="test_owner",
             repo="test_repo",
-            output_file="",
+            output_file="innersource_report.md",
         )
         result = get_env_vars(True)
         self.assertEqual(str(result), str(expected_result))
@@ -257,17 +257,13 @@ def test_get_env_vars_output_file_default_in_prod(self):
             {
                 "REPOSITORY": "test_owner/test_repo",
                 "GH_TOKEN": "TOKEN",
-                "OUTPUT_FILE": "",
             },
         ):
             # Verify the default value logic directly
-            output_file = os.getenv("OUTPUT_FILE", "")
-            self.assertEqual(output_file, "")
+            env_vars = get_env_vars(test=True)
 
             # This is the condition in get_env_vars
-            if not output_file:
-                output_file = "InnerSource_Report.md"
-            self.assertEqual(output_file, "InnerSource_Report.md")
+            self.assertEqual(env_vars.output_file, "innersource_report.md")
 
     @patch.dict(
         os.environ,
@@ -293,7 +289,7 @@ def test_get_env_vars_optionals_are_defaulted(self):
             report_title="InnerSource Report",
             owner="test_owner",
             repo="test_repo",
-            output_file="",
+            output_file="innersource_report.md",
             rate_limit_bypass=False,
         )
         result = get_env_vars(True)