Add explicit tests for temp_dir stuff

Author: kpaulisse

lib/octocatalog-diff/util/util.rb

@@ -70,7 +70,7 @@ def self.temp_dir(prefix = 'ocd-', basedir = ENV['OCTOCATALOG_DIFF_TEMPDIR'])
         the_dir = Dir.mktmpdir(prefix)
         at_exit do
           begin
-            FileUtils.remove_entry_secure the_dir
+            FileUtils.remove_entry_secure(the_dir) if File.directory?(the_dir)
           rescue Errno::ENOENT # rubocop:disable Lint/HandleExceptions
             # OK if the directory doesn't exist since we're trying to remove it anyway
           end

spec/octocatalog-diff/tests/util/util_spec.rb

@@ -84,4 +84,23 @@
       expect(result).to eq(obj)
     end
   end
+
+  describe '#temp_dir' do
+    after(:all) do
+      ENV.delete('OCTOCATALOG_DIFF_TEMPDIR')
+    end
+
+    it 'should create a temporary directory when no base directory is specified' do
+      ENV.delete('OCTOCATALOG_DIFF_TEMPDIR')
+      expect(Dir).to receive(:mktmpdir).with('ocd-').and_return('adsdasdfasdf')
+      expect(described_class.temp_dir).to eq('adsdasdfasdf')
+    end
+
+    it 'should create a temporary directory within OCTOCATALOG_DIFF_TEMPDIR when specified' do
+      ENV['OCTOCATALOG_DIFF_TEMPDIR'] = '/var/tmp/asdfasdfasdf'
+      expect(File).to receive(:'directory?').with('/var/tmp/asdfasdfasdf').and_return(true)
+      expect(Dir).to receive(:mktmpdir).with('ocd-', '/var/tmp/asdfasdfasdf').and_return('/var/tmp/asdfasdfasdf/qwertyuiop')
+      expect(described_class.temp_dir).to eq('/var/tmp/asdfasdfasdf/qwertyuiop')
+    end
+  end
 end