Create integration test demonstrating problem

Author: kpaulisse

spec/octocatalog-diff/integration/fact_file_by_branch_spec.rb

@@ -4,15 +4,15 @@
 
 require 'json'
 
-describe 'fact files by branch' do
+describe 'fact files by branch, with two fact files' do
   before(:all) do
     @result = OctocatalogDiff::Integration.integration_cli(
       [
         '-n', 'rspec-node.github.net',
         '--bootstrapped-to-dir', OctocatalogDiff::Spec.fixture_path('repos/fact-overrides'),
         '--bootstrapped-from-dir', OctocatalogDiff::Spec.fixture_path('repos/fact-overrides'),
         '--output-format', 'json',
-        '--fact-file', OctocatalogDiff::Spec.fixture_path('facts/valid-facts.yaml'),
+        '--from-fact-file', OctocatalogDiff::Spec.fixture_path('facts/valid-facts.yaml'),
         '--to-fact-file', OctocatalogDiff::Spec.fixture_path('facts/valid-facts-different-ip.yaml'),
         '--puppet-binary', OctocatalogDiff::Spec::PUPPET_BINARY,
         '--fact-override', 'foofoo=barbar',
@@ -44,3 +44,101 @@
     expect(@result.stderr).to match(/Diffs computed for rspec-node.github.net/)
   end
 end
+
+describe 'fact files by branch, with only a to fact file' do
+  before(:all) do
+    @tmpdir = Dir.mktmpdir
+    ENV['PUPPET_FACT_DIR'] = @tmpdir
+    FileUtils.cp OctocatalogDiff::Spec.fixture_path('facts/valid-facts.yaml'), File.join(@tmpdir, 'rspec-node.github.net.yaml')
+
+    @result = OctocatalogDiff::Integration.integration_cli(
+      [
+        '-n', 'rspec-node.github.net',
+        '--bootstrapped-to-dir', OctocatalogDiff::Spec.fixture_path('repos/fact-overrides'),
+        '--bootstrapped-from-dir', OctocatalogDiff::Spec.fixture_path('repos/fact-overrides'),
+        '--output-format', 'json',
+        '--to-fact-file', OctocatalogDiff::Spec.fixture_path('facts/valid-facts-different-ip.yaml'),
+        '--puppet-binary', OctocatalogDiff::Spec::PUPPET_BINARY,
+        '--fact-override', 'foofoo=barbar',
+        '-d'
+      ]
+    )
+  end
+
+  after(:all) do
+    ENV['PUPPET_FACT_DIR'] = nil
+    OctocatalogDiff::Spec.clean_up_tmpdir(@tmpdir)
+  end
+
+  it 'should exit with status 2' do
+    expect(@result.exitcode).to eq(2), @result.stderr
+  end
+
+  it 'should contain the correct diffs' do
+    parse_result = JSON.parse(@result.stdout)['diff'].map { |x| OctocatalogDiff::Spec.remove_file_and_line(x) }
+    expect(parse_result.size).to eq(1)
+    expect(parse_result).to include(
+      'diff_type' => '~',
+      'type' => 'File',
+      'title' => '/tmp/ipaddress',
+      'structure' => %w(parameters content),
+      'old_value' => '10.20.30.40',
+      'new_value' => '10.30.50.70'
+    )
+  end
+
+  it 'should log the correct messages' do
+    expect(@result.stderr).to match(/Catalog for . will be built with OctocatalogDiff::Catalog::Computed/)
+    expect(@result.stderr).to match(/Override foofoo from nil to "barbar"/)
+    expect(@result.stderr).to match(/Diffs computed for rspec-node.github.net/)
+  end
+end
+
+describe 'fact files by branch, with only a from fact file' do
+  before(:all) do
+    @tmpdir = Dir.mktmpdir
+    ENV['PUPPET_FACT_DIR'] = @tmpdir
+    FileUtils.cp OctocatalogDiff::Spec.fixture_path('facts/valid-facts.yaml'), File.join(@tmpdir, 'rspec-node.github.net.yaml')
+
+    @result = OctocatalogDiff::Integration.integration_cli(
+      [
+        '-n', 'rspec-node.github.net',
+        '--bootstrapped-to-dir', OctocatalogDiff::Spec.fixture_path('repos/fact-overrides'),
+        '--bootstrapped-from-dir', OctocatalogDiff::Spec.fixture_path('repos/fact-overrides'),
+        '--output-format', 'json',
+        '--from-fact-file', OctocatalogDiff::Spec.fixture_path('facts/valid-facts-different-ip.yaml'),
+        '--puppet-binary', OctocatalogDiff::Spec::PUPPET_BINARY,
+        '--fact-override', 'foofoo=barbar',
+        '-d'
+      ]
+    )
+  end
+
+  after(:all) do
+    ENV['PUPPET_FACT_DIR'] = nil
+    OctocatalogDiff::Spec.clean_up_tmpdir(@tmpdir)
+  end
+
+  it 'should exit with status 2' do
+    expect(@result.exitcode).to eq(2), @result.stderr
+  end
+
+  it 'should contain the correct diffs' do
+    parse_result = JSON.parse(@result.stdout)['diff'].map { |x| OctocatalogDiff::Spec.remove_file_and_line(x) }
+    expect(parse_result.size).to eq(1)
+    expect(parse_result).to include(
+      'diff_type' => '~',
+      'type' => 'File',
+      'title' => '/tmp/ipaddress',
+      'structure' => %w(parameters content),
+      'new_value' => '10.20.30.40',
+      'old_value' => '10.30.50.70'
+    )
+  end
+
+  it 'should log the correct messages' do
+    expect(@result.stderr).to match(/Catalog for . will be built with OctocatalogDiff::Catalog::Computed/)
+    expect(@result.stderr).to match(/Override foofoo from nil to "barbar"/)
+    expect(@result.stderr).to match(/Diffs computed for rspec-node.github.net/)
+  end
+end