Switch to env var for private key

Author: Thomas Osowski

app/ruby/app-issue-creator/README.md

@@ -18,6 +18,8 @@ This is the sample project that walks through creating a GitHub App and configur
 
 Install the required Ruby Gems by entering `bundle install` on the command line. 
 
+Set environment variables `GITHUB_APP_ID` and `GITHUB_APP_PRIVATE_KEY`. For example, run the following to store the private key to an environment variable: `GITHUB_APP_PRIVATE_KEY="$(less private-key.pem)"`
+
 To start the server, type `ruby server.rb` on the command line.
 
 The [sinatra server](http://www.sinatrarb.com/) will be running at `localhost:4567`.

app/ruby/app-issue-creator/server.rb

@@ -6,18 +6,13 @@
 
 begin
   GITHUB_APP_ID = ENV.fetch("GITHUB_APP_ID")
-  path_to_pem = './private-key.pem'
-  GITHUB_PRIVATE_KEY = File.read(path_to_pem)
+  GITHUB_PRIVATE_KEY = ENV.fetch("GITHUB_APP_PRIVATE_KEY")
 rescue KeyError
   $stderr.puts "To run this script, please set the following environment variables:"
   $stderr.puts "- GITHUB_APP_ID: GitHub App ID"
-  exit 1
-rescue Exception => e
-  $stderr.puts "To run this script, please copy your App's private key to this directory"
-  $stderr.puts " and rename it to `private_key.pem`"
+  $stderr.puts "- GITHUB_APP_PRIVATE_KEY: GitHub App Private Key"
   exit 1
 end
-
 @client = nil
 
 # Webhook listener
@@ -72,7 +67,7 @@ def get_app_repositories
 def create_issues(repositories, sender_username)
   repositories.each do |repo|
     begin
-      @client.create_issue(repo, "#{sender_username} created new app!", "Added GitHub App")
+      @client.create_issue(repo, "#{sender_username} added new app!", "Added GitHub App")
     rescue
       puts "Issues is disabled for this repository"
     end