-
Notifications
You must be signed in to change notification settings - Fork 291
Open
Description
Schema Inaccuracy
The "Code Samples" widget at Create a GitHub App from a manifest shows an extra Authorization Header under samples for cURL and JavaScript.
Adding an auth token in place of YOUR-TOKEN does work, but for the API to work it is not required. The documentation does not state/describe the Authorization Header, thus leaves developers to wonder what value is needed to be passed in it.
Expected
The Authorization Header in this code sample needs to be removed or ignored in the API itself. The API should not raise a 401 status if an incorrect header is passed.
Reproduction Steps
- Generate a temporary
codeusing a Github App manifest - Use this
codein the cURL call copied from Github Rest Documentation forCreate a GitHub App from a manifest
curl \
-X POST \
-H "Accept: application/vnd.github+json" \
-H "Authorization: Bearer <YOUR-TOKEN>" \
https://api.github.com/app-manifests/<code-from-step-2>/conversions