[Schema Inaccuracy] Installation schema's account property changed from union to intersection

[Jman420]

Schema Inaccuracy

The installation schema's account property has changed from an allOf to a anyOf description which results in a type which is the intersection of the two included types (simple-user & enterprise) rather than a union of the two.

"account": {
            "nullable": true,
            "anyOf": [
              {
                "$ref": "#/components/schemas/simple-user"
              },
              {
                "$ref": "#/components/schemas/enterprise"
              }
            ]
          },

Expected

The account property of the installation schema should contain the union of the simple-user and enterprise schema types so that both type's properties are accessible from the returned response.

"account": {
            "nullable": true,
            "allOf": [
              {
                "$ref": "#/components/schemas/simple-user"
              },
              {
                "$ref": "#/components/schemas/enterprise"
              }
            ]
          },

Reproduction Steps

See octokit/openapi-types.ts#305 for example of improper resulting types.

[Jman420]

Any chance of this issue and related ones being addressed?

Related issue : #2510

[wolfy1339]

Hi, is there any resolution to this?

[Jman420]

@wolfy1339 I believe this has been resolved... We no longer have any of the octokit packages pinned to lower versions in our project. Its been so long that I dont remember when or what PR addressed the issue though...

[nickfloyd]

Please let us know if this work is still needed. We're trying to follow up on any older issues to make sure they get properly routed.

[Jman420]

@nickfloyd This is an old issue indeed. I believe this issue has been resolved, although I am not sure when or how. Our project is using the latest version of Octokit without issue and Octokit uses these API descriptions for generating its APIs. I think this issue can be closed... if we encounter a similar issue we can open a new issue ticket.