[Schema Inaccuracy] issue/pr response fields marked as required nullable unnecessarily (?)

[xmo-odoo]

Schema Inaccuracy

The assignees (issue and PR) and requested_reviewers and requested_teams (PRs) are required nullable arrays.

Experimentally it doesn't look like these are ever null in responses, nor is there any reason for them to be as an empty array should play that role just fine.

[hasan-dot]

👋 @xmo-odoo from github/issues:

I couldn't find anywhere in the docs that those fields are nullable. According to the GitHub API documentation, these fields are indeed arrays, but they are not documented as nullable.
Can you please point to the problematic doc where it mentions its a nullable field?

[xmo-odoo]

@hasan-dot here is the schema for assignees in Issues:

"assignees": {
  "type": [
    "array",
    "null"
  ],

The Pull Requests are identical, and the requested_* fields are similar:

"requested_reviewers": {
  "type": [
    "array",
    "null"
  ],
[...]
"requested_teams": {
  "type": [
    "array",
    "null"
  ],

[nickfloyd]

Please let us know if this work is still needed. We're trying to follow up on any older issues to make sure they get properly routed.

[xmo-odoo]

Please let us know if this work is still needed. We're trying to follow up on any older issues to make sure they get properly routed.

The schema seems to have been modified but not in a way which changes this (so possibly a change in the schema generator?)

For instance for the issue assignees I can now see this:

$ jq '.components.schemas.issue.properties.assignees' api.github.com.json
{
  "type": "array",
  "items": {
    "$ref": "#/components/schemas/simple-user"
  },
  "nullable": true
}

so unless I'm misreading the openapi the assignees field is defined as an array which is nullable, which as noted above doesn't seem useful or used. For instance if we check the API version of this very issue we get "assignees": [] not "assignees": null