Skip to content

[Schema Inaccuracy] Issue event rename "from" and "to" fields can be null #5705

@bigfootjon

Description

@bigfootjon

Schema Inaccuracy

Spec:

issue-event-rename": {
        "title": "Issue Event Rename",
        "description": "Issue Event Rename",
        "type": "object",
        "properties": {
          "from": {
            "type": "string"
          },
          "to": {
            "type": "string"
          }
        },
        "required": [
          "from",
          "to"
        ]
      },

Expected

Based on the above, since from and to are marked as required they should not be null in the data, but see an example below

Reproduction Steps

https://api.github.com/repos/golang/go/issues/50851/events?sort=updated&direction=desc&per_page=100

...
{
    "id": 5963856655,
    "node_id": "RTE_lADOAWBuf85CiGTczwAAAAFjeTsP",
    "url": "https://api.github.com/repos/golang/go/issues/events/5963856655",
    "actor": {
      "login": "hyangah",
      "id": 4999471,
      "node_id": "MDQ6VXNlcjQ5OTk0NzE=",
      "avatar_url": "https://avatars.githubusercontent.com/u/4999471?v=4",
      "gravatar_id": "",
      "url": "https://api.github.com/users/hyangah",
      "html_url": "https://github.com/hyangah",
      "followers_url": "https://api.github.com/users/hyangah/followers",
      "following_url": "https://api.github.com/users/hyangah/following{/other_user}",
      "gists_url": "https://api.github.com/users/hyangah/gists{/gist_id}",
      "starred_url": "https://api.github.com/users/hyangah/starred{/owner}{/repo}",
      "subscriptions_url": "https://api.github.com/users/hyangah/subscriptions",
      "organizations_url": "https://api.github.com/users/hyangah/orgs",
      "repos_url": "https://api.github.com/users/hyangah/repos",
      "events_url": "https://api.github.com/users/hyangah/events{/privacy}",
      "received_events_url": "https://api.github.com/users/hyangah/received_events",
      "type": "User",
      "user_view_type": "public",
      "site_admin": false
    },
    "event": "renamed",
    "commit_id": null,
    "commit_url": null,
    "created_at": "2022-01-27T13:46:50Z",
    "rename": {
      "from": null,
      "to": null
    },
    "performed_via_github_app": null
  },
...

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions