Merge pull request #183 from github/jdennes/fix-render-literal-cop-message

`RuboCop::Cop::GitHub::RailsControllerRenderLiteral`: Make error message helpful for `locals` offence

Author: jdennes

lib/rubocop/cop/github/rails_controller_render_literal.rb

@@ -9,7 +9,7 @@ module GitHub
       class RailsControllerRenderLiteral < Base
         include RenderLiteralHelpers
 
-        MSG = "render must be used with a string literal or an instance of a Class"
+        MSG = "render must be used with a string literal or an instance of a Class, and use literals for locals keys"
 
         def_node_matcher :ignore_key?, <<-PATTERN
           (pair (sym {

test/test_rails_controller_render_literal.rb

@@ -274,7 +274,9 @@ def index
     RUBY
 
     assert_equal 1, offenses.count
-    assert_equal "#{cop.name}: render must be used with a string literal or an instance of a Class", offenses[0].message
+    assert_equal \
+      "#{cop.name}: render must be used with a string literal or an instance of a Class, and use literals for locals keys",
+      offenses[0].message
   end
 
   def test_render_implicit_with_layout_offense
@@ -287,7 +289,9 @@ def index
     RUBY
 
     assert_equal 1, offenses.count
-    assert_equal "#{cop.name}: render must be used with a string literal or an instance of a Class", offenses[0].message
+    assert_equal \
+      "#{cop.name}: render must be used with a string literal or an instance of a Class, and use literals for locals keys",
+      offenses[0].message
   end
 
   def test_render_implicit_with_status_offense
@@ -300,7 +304,9 @@ def index
     RUBY
 
     assert_equal 1, offenses.count
-    assert_equal "#{cop.name}: render must be used with a string literal or an instance of a Class", offenses[0].message
+    assert_equal \
+      "#{cop.name}: render must be used with a string literal or an instance of a Class, and use literals for locals keys",
+      offenses[0].message
   end
 
   def test_render_variable_offense
@@ -313,7 +319,9 @@ def index
     RUBY
 
     assert_equal 1, offenses.count
-    assert_equal "#{cop.name}: render must be used with a string literal or an instance of a Class", offenses[0].message
+    assert_equal \
+      "#{cop.name}: render must be used with a string literal or an instance of a Class, and use literals for locals keys",
+      offenses[0].message
   end
 
   def test_render_to_string_variable_offense
@@ -326,7 +334,9 @@ def index
     RUBY
 
     assert_equal 1, offenses.count
-    assert_equal "#{cop.name}: render must be used with a string literal or an instance of a Class", offenses[0].message
+    assert_equal \
+      "#{cop.name}: render must be used with a string literal or an instance of a Class, and use literals for locals keys",
+      offenses[0].message
   end
 
   def test_render_action_variable_offense
@@ -339,7 +349,9 @@ def index
     RUBY
 
     assert_equal 1, offenses.count
-    assert_equal "#{cop.name}: render must be used with a string literal or an instance of a Class", offenses[0].message
+    assert_equal \
+      "#{cop.name}: render must be used with a string literal or an instance of a Class, and use literals for locals keys",
+      offenses[0].message
   end
 
   def test_render_template_variable_offense
@@ -352,7 +364,9 @@ def index
     RUBY
 
     assert_equal 1, offenses.count
-    assert_equal "#{cop.name}: render must be used with a string literal or an instance of a Class", offenses[0].message
+    assert_equal \
+      "#{cop.name}: render must be used with a string literal or an instance of a Class, and use literals for locals keys",
+      offenses[0].message
   end
 
   def test_render_partial_variable_offense
@@ -365,7 +379,9 @@ def index
     RUBY
 
     assert_equal 1, offenses.count
-    assert_equal "#{cop.name}: render must be used with a string literal or an instance of a Class", offenses[0].message
+    assert_equal \
+      "#{cop.name}: render must be used with a string literal or an instance of a Class, and use literals for locals keys",
+      offenses[0].message
   end
 
   def test_render_template_with_layout_variable_offense
@@ -378,7 +394,9 @@ def index
     RUBY
 
     assert_equal 1, offenses.count
-    assert_equal "#{cop.name}: render must be used with a string literal or an instance of a Class", offenses[0].message
+    assert_equal \
+      "#{cop.name}: render must be used with a string literal or an instance of a Class, and use literals for locals keys",
+      offenses[0].message
   end
 
   def test_render_template_variable_with_layout_offense
@@ -391,7 +409,9 @@ def index
     RUBY
 
     assert_equal 1, offenses.count
-    assert_equal "#{cop.name}: render must be used with a string literal or an instance of a Class", offenses[0].message
+    assert_equal \
+      "#{cop.name}: render must be used with a string literal or an instance of a Class, and use literals for locals keys",
+      offenses[0].message
   end
 
   def test_render_shorthand_static_locals_no_offsense