Skip to content

Commit 0c9f149

Browse files
authored
Launchable: Fix launchable record session command failures (ruby#12810)
Currently, the `launchable record session` command is failing some workflows such as YJIT on macOS. This occurs because of word splitting, as explained in https://www.shellcheck.net/wiki/SC2086. This PR addresses the issue. ``` + launchable record session --build refs_pull_12785_merge_5ac818aaf7402e232de6b3e1b078765da3dc6279 --observation --flavor os=macos-14 --flavor test_task=check --flavor test_opts=--enable-yjit --flavor workflow=YJIT macOS Arm64 --test-suite yjit-test-all Usage: launchable record session [OPTIONS] Try 'launchable record session --help' for help. Error: Got unexpected extra arguments (macOS Arm64) Error: Process completed with exit code 2. ``` https://github.com/ruby/ruby/actions/runs/13535324545/job/37825826044#step:10:354
1 parent 1419292 commit 0c9f149

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

.github/actions/launchable/setup/action.yml

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -159,10 +159,10 @@ runs:
159159
launchable record session \
160160
--build "${build_name}" \
161161
--observation \
162-
--flavor os=${{ inputs.os }} \
163-
--flavor test_task=${{ inputs.test-task }} \
164-
--flavor test_opts=${test_opts} \
165-
--flavor workflow=${{ github.workflow }} \
162+
--flavor os="${{ inputs.os }}" \
163+
--flavor test_task="${{ inputs.test-task }}" \
164+
--flavor test_opts="${test_opts}" \
165+
--flavor workflow="${{ github.workflow }}" \
166166
--test-suite ${test_all_test_suite} \
167167
> "${test_all_session_file}"
168168
launchable subset \
@@ -177,10 +177,10 @@ runs:
177177
launchable record session \
178178
--build "${build_name}" \
179179
--observation \
180-
--flavor os=${{ inputs.os }} \
181-
--flavor test_task=${{ inputs.test-task }} \
182-
--flavor test_opts=${test_opts} \
183-
--flavor workflow=${{ github.workflow }} \
180+
--flavor os="${{ inputs.os }}" \
181+
--flavor test_task="${{ inputs.test-task }}" \
182+
--flavor test_opts="${test_opts}" \
183+
--flavor workflow="${{ github.workflow }}" \
184184
--test-suite ${btest_test_suite} \
185185
> "${btest_session_file}"
186186
launchable subset \
@@ -195,10 +195,10 @@ runs:
195195
launchable record session \
196196
--build "${build_name}" \
197197
--observation \
198-
--flavor os=${{ inputs.os }} \
199-
--flavor test_task=${{ inputs.test-task }} \
200-
--flavor test_opts=${test_opts} \
201-
--flavor workflow=${{ github.workflow }} \
198+
--flavor os="${{ inputs.os }}" \
199+
--flavor test_task="${{ inputs.test-task }}" \
200+
--flavor test_opts="${test_opts}" \
201+
--flavor workflow="${{ github.workflow }}" \
202202
--test-suite ${test_spec_test_suite} \
203203
> "${test_spec_session_file}"
204204
launchable subset \

0 commit comments

Comments
 (0)