Skip to content

Commit 11275d1

Browse files
authored
ZJIT: Merge make check jobs (ruby#14459)
1 parent cd07c3c commit 11275d1

File tree

2 files changed

+23
-33
lines changed

2 files changed

+23
-33
lines changed

.github/workflows/zjit-macos.yml

Lines changed: 11 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -32,28 +32,22 @@ jobs:
3232
fail-fast: false
3333
matrix:
3434
include:
35-
- test_task: 'zjit-check'
35+
- test_task: 'check'
36+
configure: '--enable-zjit=dev'
37+
run_opts: '--zjit-call-threshold=1'
38+
specopts: '-T --zjit-call-threshold=1'
39+
40+
- test_task: 'zjit-check' # zjit-test + quick feedback of test_zjit.rb
3641
configure: '--enable-yjit=dev --enable-zjit'
3742
rust_version: "1.85.0"
3843

39-
- test_task: 'ruby' # build test for combo build
44+
- test_task: 'ruby'
45+
hint: 'combo build test'
4046
configure: '--enable-yjit --enable-zjit'
4147

42-
- test_task: 'zjit-test-all'
43-
configure: '--enable-zjit=dev'
44-
testopts: '--seed=11831'
45-
46-
- test_task: 'test'
47-
configure: '--enable-zjit=dev'
48-
zjit_opts: '--zjit-call-threshold=1'
49-
50-
- test_task: 'test-spec'
51-
configure: '--enable-zjit=dev'
52-
specopts: '-T --zjit-call-threshold=1'
53-
5448
env:
5549
GITPULLOPTIONS: --no-tags origin ${{ github.ref }}
56-
RUN_OPTS: ${{ matrix.zjit_opts }}
50+
RUN_OPTS: ${{ matrix.run_opts }}
5751
SPECOPTS: ${{ matrix.specopts }}
5852
TESTOPTS: ${{ matrix.testopts }}
5953

@@ -117,13 +111,15 @@ jobs:
117111
RUN_OPTS="$RUN_OPTS"
118112
SPECOPTS="$SPECOPTS"
119113
TESTOPTS="$TESTOPTS"
114+
TEST_EXCLUDES="$TEST_EXCLUDES"
120115
timeout-minutes: 60
121116
env:
122117
RUBY_TESTOPTS: '-q --tty=no'
123118
TEST_BUNDLED_GEMS_ALLOW_FAILURES: ''
124119
SYNTAX_SUGGEST_TIMEOUT: '5'
125120
PRECHECK_BUNDLED_GEMS: 'no'
126121
TESTS: ${{ matrix.tests }}
122+
TEST_EXCLUDES: '--excludes-dir=../src/test/.excludes-zjit --name=!/memory_leak/'
127123
continue-on-error: ${{ matrix.continue-on-test_task || false }}
128124

129125
result:

.github/workflows/zjit-ubuntu.yml

Lines changed: 12 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -51,30 +51,23 @@ jobs:
5151
fail-fast: false
5252
matrix:
5353
include:
54-
- test_task: 'zjit-bindgen'
55-
hint: 'To fix: use patch in logs'
56-
configure: '--enable-zjit=dev --with-gcc=clang-14'
57-
libclang_path: '/usr/lib/llvm-14/lib/libclang.so.1'
54+
- test_task: 'check'
55+
configure: '--enable-zjit=dev'
56+
run_opts: '--zjit-call-threshold=1'
57+
specopts: '-T --zjit-call-threshold=1'
5858

59-
- test_task: 'zjit-check'
59+
- test_task: 'zjit-check' # zjit-test + quick feedback of test_zjit.rb
6060
configure: '--enable-yjit --enable-zjit=dev'
6161
rust_version: '1.85.0'
6262

63-
- test_task: 'zjit-test-all'
64-
configure: '--enable-zjit=dev'
65-
testopts: '--seed=18140'
66-
67-
- test_task: 'test'
68-
configure: '--enable-zjit=dev'
69-
zjit_opts: '--zjit-call-threshold=1'
70-
71-
- test_task: 'test-spec'
72-
configure: '--enable-zjit=dev'
73-
specopts: '-T --zjit-call-threshold=1'
63+
- test_task: 'zjit-bindgen'
64+
hint: 'To fix: use patch in logs'
65+
configure: '--enable-zjit=dev --with-gcc=clang-14'
66+
libclang_path: '/usr/lib/llvm-14/lib/libclang.so.1'
7467

7568
env:
7669
GITPULLOPTIONS: --no-tags origin ${{ github.ref }}
77-
RUN_OPTS: ${{ matrix.zjit_opts }}
70+
RUN_OPTS: ${{ matrix.run_opts }}
7871
YJIT_BENCH_OPTS: ${{ matrix.yjit_bench_opts }}
7972
SPECOPTS: ${{ matrix.specopts }}
8073
TESTOPTS: ${{ matrix.testopts }}
@@ -156,12 +149,13 @@ jobs:
156149
run: >-
157150
make -s ${{ matrix.test_task }} ${TESTS:+TESTS="$TESTS"}
158151
RUN_OPTS="$RUN_OPTS" MSPECOPT=--debug SPECOPTS="$SPECOPTS"
159-
TESTOPTS="$TESTOPTS"
152+
TESTOPTS="$TESTOPTS" TEST_EXCLUDES="$TEST_EXCLUDES"
160153
ZJIT_BINDGEN_DIFF_OPTS="$ZJIT_BINDGEN_DIFF_OPTS"
161154
timeout-minutes: 90
162155
env:
163156
RUBY_TESTOPTS: '-q --tty=no'
164157
TEST_BUNDLED_GEMS_ALLOW_FAILURES: ''
158+
TEST_EXCLUDES: '--excludes-dir=../src/test/.excludes-zjit --name=!/memory_leak/'
165159
PRECHECK_BUNDLED_GEMS: 'no'
166160
SYNTAX_SUGGEST_TIMEOUT: '5'
167161
ZJIT_BINDGEN_DIFF_OPTS: '--exit-code'

0 commit comments

Comments
 (0)