Move grouping by upstreams to SyncDefaultGems::Repository

It is also useful to distribution changes to each upstream repository.

Author: nobu

tool/auto_review_pr.rb

@@ -46,7 +46,7 @@ def review(pr_number)
     changed_files = @client.get("/repos/#{REPO}/pulls/#{pr_number}/files").map { it.fetch(:filename) }
 
     # Build a Hash: { upstream_repo => files, ... }
-    upstream_repos = changed_files.group_by { |file| find_upstream_repo(file) }
+    upstream_repos = SyncDefaultGems::Repository.group(changed_files)
     upstream_repos.delete(nil) # exclude no-upstream files
     upstream_repos.delete('prism') if changed_files.include?('prism_compile.c') # allow prism changes in this case
     if upstream_repos.empty?
@@ -70,17 +70,6 @@ def review(pr_number)
 
   private
 
-  def find_upstream_repo(file)
-    SyncDefaultGems::REPOSITORIES.each do |repo_name, repository|
-      repository.mappings.each do |_src, dst|
-        if file.start_with?(dst)
-          return repo_name
-        end
-      end
-    end
-    nil
-  end
-
   # upstream_repos: { upstream_repo => files, ... }
   def format_comment(upstream_repos)
     comment = +''

tool/sync_default_gems.rb

@@ -293,6 +293,20 @@ def lib((upstream, branch), gemspec_in_subdir: false)
     ]),
   }.transform_keys(&:to_s)
 
+  class << Repository
+    def find_upstream(file)
+      REPOSITORIES.find do |repo_name, repository|
+        if repository.mappings.any? {|_src, dst| file.start_with?(dst) }
+          break repo_name
+        end
+      end
+    end
+
+    def group(files)
+      files.group_by {|file| find_upstream(file)}
+    end
+  end
+
   # Allow synchronizing commits up to this FETCH_DEPTH. We've historically merged PRs
   # with about 250 commits to ruby/ruby, so we use this depth for ruby/ruby in general.
   FETCH_DEPTH = 500