[ruby/fileutils] FileUtils.remove_dir checks directory

ruby/fileutils@f0d7fc817b

Author: sferik

lib/fileutils.rb

@@ -1487,7 +1487,8 @@ def remove_file(path, force = false)
   # Related: {methods for deleting}[rdoc-ref:FileUtils@Deleting].
   #
   def remove_dir(path, force = false)
-    remove_entry path, force   # FIXME?? check if it is a directory
+    raise Errno::ENOTDIR, path unless File.directory?(path)
+    remove_entry path, force
   end
   module_function :remove_dir
 

test/fileutils/test_fileutils.rb

@@ -1812,6 +1812,14 @@ def test_remove_dir_file_perm
     assert_file_not_exist 'data/tmpdir'
   end if have_file_perm?
 
+  def test_remove_dir_with_file
+    File.write('data/tmpfile', 'dummy')
+    assert_raise(Errno::ENOTDIR) { remove_dir 'data/tmpfile' }
+    assert_file_exist 'data/tmpfile'
+  ensure
+    File.unlink('data/tmpfile') if File.exist?('data/tmpfile')
+  end
+
   def test_compare_file
     check_singleton :compare_file
     # FIXME