Skip to content

Commit 4d9a1d5

Browse files
committed
Handle to look up CGI::EscapeExt instead of using LoadError. cgi/escape is provided snce Ruby 2.3
1 parent c405570 commit 4d9a1d5

File tree

7 files changed

+14
-35
lines changed

7 files changed

+14
-35
lines changed

lib/bundler/fetcher/dependency.rb

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,8 @@
11
# frozen_string_literal: true
22

33
require_relative "base"
4-
begin
5-
require "cgi/escape"
6-
rescue LoadError
7-
require "cgi/util"
8-
end
4+
require "cgi/escape"
5+
require "cgi/util" unless defined?(CGI::EscapeExt)
96

107
module Bundler
118
class Fetcher

lib/bundler/friendly_errors.rb

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -102,11 +102,8 @@ def serialized_exception_for(e)
102102
def issues_url(exception)
103103
message = exception.message.lines.first.tr(":", " ").chomp
104104
message = message.split("-").first if exception.is_a?(Errno)
105-
begin
106-
require "cgi/escape"
107-
rescue LoadError
108-
require "cgi/util"
109-
end
105+
require "cgi/escape"
106+
require "cgi/util" unless defined?(CGI::EscapeExt)
110107
"https://github.com/rubygems/rubygems/search?q=" \
111108
"#{CGI.escape(message)}&type=Issues"
112109
end

lib/bundler/vendor/net-http-persistent/lib/net/http/persistent.rb

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,7 @@
11
require_relative '../../../../../vendored_net_http'
22
require_relative '../../../../../vendored_uri'
3-
begin
4-
require 'cgi/escape'
5-
rescue LoadError
6-
require 'cgi/util' # for escaping
7-
end
3+
require 'cgi/escape'
4+
require 'cgi/util' unless defined?(CGI::EscapeExt)
85
require_relative '../../../../connection_pool/lib/connection_pool'
96

107
autoload :OpenSSL, 'openssl'

lib/net/http.rb

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1917,11 +1917,8 @@ def proxy_pass
19171917
private
19181918

19191919
def unescape(value)
1920-
begin
1921-
require "cgi/escape"
1922-
rescue LoadError
1923-
require "cgi/util"
1924-
end
1920+
require 'cgi/escape'
1921+
require 'cgi/util' unless defined?(CGI::EscapeExt)
19251922
CGI.unescape(value)
19261923
end
19271924

lib/rubygems/uri_formatter.rb

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,8 @@ class Gem::UriFormatter
1717
# Creates a new URI formatter for +uri+.
1818

1919
def initialize(uri)
20-
begin
21-
require "cgi/escape"
22-
rescue LoadError
23-
require "cgi/util"
24-
end
20+
require "cgi/escape"
21+
require "cgi/util" unless defined?(CGI::EscapeExt)
2522

2623
@uri = uri
2724
end

lib/rubygems/vendor/net-http/lib/net/http.rb

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1923,11 +1923,8 @@ def proxy_pass
19231923
private
19241924

19251925
def unescape(value)
1926-
begin
1927-
require "cgi/escape"
1928-
rescue LoadError
1929-
require "cgi/util"
1930-
end
1926+
require 'cgi/escape'
1927+
require 'cgi/util' unless defined?(CGI::EscapeExt)
19311928
CGI.unescape(value)
19321929
end
19331930

prism/templates/lib/prism/dot_visitor.rb.erb

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
1-
begin
2-
require "cgi/escape"
3-
rescue LoadError
4-
require "cgi/util"
5-
end
1+
require "cgi/escape"
2+
require "cgi/util" unless defined?(CGI::EscapeExt)
63

74
module Prism
85
# This visitor provides the ability to call Node#to_dot, which converts a

0 commit comments

Comments
 (0)