Skip to content

Commit 6e2bf5d

Browse files
aguspenobu
authored andcommitted
[Tests] Assert Module#set_temporary_name returns self
The return value of Module#set_temporary_name was changed to return `self`, but the existing tests did not verify this.
1 parent ceea806 commit 6e2bf5d

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

test/ruby/test_module.rb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3367,26 +3367,26 @@ def test_set_temporary_name
33673367
m.const_set(:N, Module.new)
33683368

33693369
assert_match(/\A#<Module:0x\h+>::N\z/, m::N.name)
3370-
m::N.set_temporary_name(name = "fake_name_under_M")
3370+
assert_same m::N, m::N.set_temporary_name(name = "fake_name_under_M")
33713371
name.upcase!
33723372
assert_equal("fake_name_under_M", m::N.name)
33733373
assert_raise(FrozenError) {m::N.name.upcase!}
3374-
m::N.set_temporary_name(nil)
3374+
assert_same m::N, m::N.set_temporary_name(nil)
33753375
assert_nil(m::N.name)
33763376

33773377
m::N.const_set(:O, Module.new)
33783378
m.const_set(:Recursive, m)
33793379
m::N.const_set(:Recursive, m)
33803380
m.const_set(:A, 42)
33813381

3382-
m.set_temporary_name(name = "fake_name")
3382+
assert_same m, m.set_temporary_name(name = "fake_name")
33833383
name.upcase!
33843384
assert_equal("fake_name", m.name)
33853385
assert_raise(FrozenError) {m.name.upcase!}
33863386
assert_equal("fake_name::N", m::N.name)
33873387
assert_equal("fake_name::N::O", m::N::O.name)
33883388

3389-
m.set_temporary_name(nil)
3389+
assert_same m, m.set_temporary_name(nil)
33903390
assert_nil m.name
33913391
assert_nil m::N.name
33923392
assert_nil m::N::O.name

variable.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -279,7 +279,7 @@ set_sub_temporary_name(VALUE mod, VALUE name)
279279
* m.name #=> nil
280280
*
281281
* c = Class.new
282-
* c.set_temporary_name("MyClass(with description)")
282+
* c.set_temporary_name("MyClass(with description)") # => MyClass(with description)
283283
*
284284
* c.new # => #<MyClass(with description):0x0....>
285285
*

0 commit comments

Comments
 (0)