[rubygems/rubygems] Make global_gem_cache flag to settings

ruby/rubygems@bfe15a4712

Co-authored-by: David Rodríguez <[email protected]>

Author: 2 people

lib/bundler/feature_flag.rb

@@ -27,7 +27,6 @@ def self.settings_method(name, key, &default)
 
     (1..10).each {|v| define_method("bundler_#{v}_mode?") { @major_version >= v } }
 
-    settings_flag(:global_gem_cache) { bundler_5_mode? }
     settings_flag(:update_requires_all_flag) { bundler_5_mode? }
 
     settings_option(:default_cli_command) { bundler_4_mode? ? :cli_help : :install }

lib/bundler/settings.rb

@@ -84,6 +84,7 @@ class Settings
       "BUNDLE_LOCKFILE_CHECKSUMS" => true,
       "BUNDLE_CACHE_ALL" => true,
       "BUNDLE_PLUGINS" => true,
+      "BUNDLE_GLOBAL_GEM_CACHE" => false,
     }.freeze
 
     def initialize(root = nil)

lib/bundler/source.rb

@@ -79,7 +79,7 @@ def path?
     end
 
     def extension_cache_path(spec)
-      return unless Bundler.feature_flag.global_gem_cache?
+      return unless Bundler.settings[:global_gem_cache]
       return unless source_slug = extension_cache_slug(spec)
       Bundler.user_cache.join(
         "extensions", Gem::Platform.local.to_s, Bundler.ruby_scope,

lib/bundler/source/git.rb

@@ -238,7 +238,7 @@ def load_spec_files
       # across different projects, this cache will be shared.
       # When using local git repos, this is set to the local repo.
       def cache_path
-        @cache_path ||= if Bundler.feature_flag.global_gem_cache?
+        @cache_path ||= if Bundler.settings[:global_gem_cache]
           Bundler.user_cache
         else
           Bundler.bundle_path.join("cache", "bundler")

lib/bundler/source/rubygems.rb

@@ -493,7 +493,7 @@ def download_gem(spec, download_cache_path, previous_spec = nil)
       # @return [Pathname] The global cache path.
       #
       def download_cache_path(spec)
-        return unless Bundler.feature_flag.global_gem_cache?
+        return unless Bundler.settings[:global_gem_cache]
         return unless remote = spec.remote
         return unless cache_slug = remote.cache_slug