Fix an off by one in rb_ary_resize

byroot · byroot · commit bf225feb265a · 2024-12-04T22:46:02.000+01:00
When setting len to X we only need to grow the array
if len is bigger than capa. If they're equal we don't need to
increase capacity.
diff --git a/array.c b/array.c
@@ -2304,7 +2304,7 @@ rb_ary_resize(VALUE ary, long len)
         rb_raise(rb_eIndexError, "index %ld too big", len);
     }
     if (len > olen) {
-        if (len >= ARY_CAPA(ary)) {
+        if (len > ARY_CAPA(ary)) {
             ary_double_capa(ary, len);
         }
         ary_mem_clear(ary, olen, len - olen);

Original file line number	Diff line number	Diff line change
`@@ -2304,7 +2304,7 @@ rb_ary_resize(VALUE ary, long len)`
`2304`	`2304`	`rb_raise(rb_eIndexError, "index %ld too big", len);`
`2305`	`2305`	`}`
`2306`	`2306`	`if (len > olen) {`
`2307`		`- if (len >= ARY_CAPA(ary)) {`
	`2307`	`+ if (len > ARY_CAPA(ary)) {`
`2308`	`2308`	`ary_double_capa(ary, len);`
`2309`	`2309`	`}`
`2310`	`2310`	`ary_mem_clear(ary, olen, len - olen);`