[ruby/psych] Avoid calls to require in hotspots

byroot · hsbt · commit c1f024f99d4f · 2025-02-14T16:13:26.000+09:00
Followup: ruby/psych#686 This single call shows up as 4% of some controller actions in the lobsters benchmark. Profile: https://share.firefox.dev/3EqKnhS ruby/psych@b77bfee092
diff --git a/ext/psych/lib/psych/nodes/node.rb b/ext/psych/lib/psych/nodes/node.rb
@@ -55,7 +55,8 @@ def to_ruby(symbolize_names: false, freeze: false, strict_integer: false)
       #
       # See also Psych::Visitors::Emitter
       def yaml io = nil, options = {}
-        require "stringio"
+        require "stringio" unless defined?(StringIO)
+
         real_io = io || StringIO.new(''.encode('utf-8'))
 
         Visitors::Emitter.new(real_io, options).accept self

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,8 @@ def to_ruby(symbolize_names: false, freeze: false, strict_integer: false)`
`55`	`55`	`#`
`56`	`56`	`# See also Psych::Visitors::Emitter`
`57`	`57`	`def yaml io = nil, options = {}`
`58`		`- require "stringio"`
	`58`	`+ require "stringio" unless defined?(StringIO)`
	`59`	`+`
`59`	`60`	`real_io = io \|\| StringIO.new(''.encode('utf-8'))`
`60`	`61`
`61`	`62`	`Visitors::Emitter.new(real_io, options).accept self`