Skip to content

Commit c6a27a0

Browse files
committed
ZJII: Address review feedback
1 parent 180469a commit c6a27a0

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

tool/zjit_bisect.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
require 'tempfile'
77
require 'timeout'
88

9-
ARGS = {:timeout => 5}
9+
ARGS = {timeout: 5}
1010
OptionParser.new do |opts|
1111
opts.banner += " <path_to_ruby> -- <options>"
1212
opts.on("--timeout=TIMEOUT_SEC", "Seconds until child process is killed") do |timeout|
@@ -76,7 +76,7 @@ def run_ruby *cmd
7676
stdout_data = nil
7777
stderr_data = nil
7878
status = nil
79-
Open3.popen3(Shellwords.join cmd) do |stdin, stdout, stderr, wait_thr|
79+
Open3.popen3(*cmd) do |stdin, stdout, stderr, wait_thr|
8080
pid = wait_thr.pid
8181
begin
8282
Timeout.timeout(ARGS[:timeout]) do
@@ -128,7 +128,7 @@ def run_with_jit_list(ruby, options, jit_list)
128128
file.puts(result)
129129
end
130130
puts "Run:"
131-
command = Shellwords.join [RUBY, "--zjit-allowed-iseqs=jitlist.txt", *OPTIONS]
131+
command = [RUBY, "--zjit-allowed-iseqs=jitlist.txt", *OPTIONS].shelljoin
132132
puts command
133133
puts "Reduced JIT list (available in jitlist.txt):"
134134
puts result

0 commit comments

Comments
 (0)