Skip to content

Commit c7391a0

Browse files
committed
merge revision(s) r44516,r46159,r46196: [Backport ruby#8523]
test_timeout.rb: shorten waiting times * test/test_timeout.rb (test_timeout): inverted test condition. [Bug ruby#8523] git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_1@46810 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
1 parent 390e923 commit c7391a0

File tree

4 files changed

+30
-13
lines changed

4 files changed

+30
-13
lines changed

ChangeLog

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
Sun Jul 13 23:28:41 2014 SHIBATA Hiroshi <[email protected]>
2+
3+
* test/test_timeout.rb (test_timeout): inverted test condition.
4+
[Bug #8523]
5+
16
Sun Jul 13 23:18:11 2014 Nobuyoshi Nakada <[email protected]>
27

38
* ext/digest/digest.c (rb_digest_instance_equal): no need to call

test/ruby/test_thread.rb

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -358,6 +358,24 @@ def test_status_and_stop_p
358358
c.kill if c
359359
end
360360

361+
def test_switch_while_busy_loop
362+
bug1402 = "[ruby-dev:38319] [Bug #1402]"
363+
flag = true
364+
th = Thread.current
365+
waiter = Thread.start {
366+
sleep 0.1
367+
flag = false
368+
sleep 1
369+
th.raise(bug1402)
370+
}
371+
assert_nothing_raised(RuntimeError, bug1402) do
372+
nil while flag
373+
end
374+
assert(!flag, bug1402)
375+
ensure
376+
waiter.kill.join
377+
end
378+
361379
def test_safe_level
362380
ok = false
363381
t = Thread.new do

test/test_timeout.rb

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -6,22 +6,16 @@ class TestTimeout < Test::Unit::TestCase
66
def test_queue
77
q = Queue.new
88
assert_raise(Timeout::Error, "[ruby-dev:32935]") {
9-
timeout(0.1) { q.pop }
9+
timeout(0.01) { q.pop }
1010
}
1111
end
1212

1313
def test_timeout
14-
@flag = true
15-
Thread.start {
16-
sleep 0.1
17-
@flag = false
18-
}
19-
assert_nothing_raised("[ruby-dev:38319]") do
20-
Timeout.timeout(1) {
21-
nil while @flag
14+
assert_raise(Timeout::Error) do
15+
Timeout.timeout(0.1) {
16+
nil while true
2217
}
2318
end
24-
assert !@flag, "[ruby-dev:38319]"
2519
end
2620

2721
def test_cannot_convert_into_time_interval
@@ -34,7 +28,7 @@ def test_skip_rescue
3428
bug8730 = '[Bug #8730]'
3529
e = nil
3630
assert_raise_with_message(Timeout::Error, /execution expired/, bug8730) do
37-
timeout 0.1 do
31+
timeout 0.01 do
3832
begin
3933
sleep 3
4034
rescue Exception => e
@@ -48,7 +42,7 @@ def test_rescue_exit
4842
exc = Class.new(RuntimeError)
4943
e = nil
5044
assert_nothing_raised(exc) do
51-
timeout 0.1, exc do
45+
timeout 0.01, exc do
5246
begin
5347
sleep 3
5448
rescue exc => e

version.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#define RUBY_VERSION "2.1.2"
22
#define RUBY_RELEASE_DATE "2014-07-13"
3-
#define RUBY_PATCHLEVEL 174
3+
#define RUBY_PATCHLEVEL 175
44

55
#define RUBY_RELEASE_YEAR 2014
66
#define RUBY_RELEASE_MONTH 7

0 commit comments

Comments
 (0)