Stop cloning the repository into another path

which seems to prevent it from fetching notes when the path is not the
actual repository but a shallow-cloned repository.

Author: k0kubun

.github/workflows/check_misc.yml

@@ -62,17 +62,6 @@ jobs:
           GITHUB_NEW_SHA: ${{ github.event.pull_request.merge_commit_sha }}
         if: ${{ github.repository == 'ruby/ruby' && startsWith(github.event_name, 'pull') }}
 
-      - name: Push PR notes to GitHub
-        run: ruby tool/notes-github-pr.rb "$(pwd)/.git" "$GITHUB_OLD_SHA" "$GITHUB_NEW_SHA" refs/heads/master
-        env:
-          GITHUB_OLD_SHA: ${{ github.event.before }}
-          GITHUB_NEW_SHA: ${{ github.event.after }}
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          GIT_AUTHOR_NAME: git
-          GIT_COMMITTER_NAME: git
-          EMAIL: [email protected]
-        if: ${{ github.repository == 'ruby/ruby' && github.ref == 'refs/heads/master' && github.event_name == 'push' }}
-
       - name: Check if C-sources are US-ASCII
         run: |
           grep -r -n --include='*.[chyS]' --include='*.asm' $'[^\t-~]' -- . && exit 1 || :
@@ -143,6 +132,17 @@ jobs:
           name: ${{ steps.docs.outputs.htmlout }}
         if: ${{ steps.docs.outcome == 'success' }}
 
+      - name: Push PR notes to GitHub
+        run: ruby tool/notes-github-pr.rb "$(pwd)/.git" "$GITHUB_OLD_SHA" "$GITHUB_NEW_SHA" refs/heads/master
+        env:
+          GITHUB_OLD_SHA: ${{ github.event.before }}
+          GITHUB_NEW_SHA: ${{ github.event.after }}
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          GIT_AUTHOR_NAME: git
+          GIT_COMMITTER_NAME: git
+          EMAIL: [email protected]
+        if: ${{ github.repository == 'ruby/ruby' && github.ref == 'refs/heads/master' && github.event_name == 'push' }}
+
       - uses: ./.github/actions/slack
         with:
           SLACK_WEBHOOK_URL: ${{ secrets.SIMPLER_ALERTS_URL }} # ruby-lang slack: ruby/simpler-alerts-bot

tool/notes-github-pr.rb

@@ -103,45 +103,36 @@ def git(*cmd, repo_path: nil)
 github = GitHub.new(ENV.fetch('GITHUB_TOKEN'))
 
 repo_path, *rest = ARGV
-rest.each_slice(3).map do |oldrev, newrev, refname|
-  branch = Git.abbrev_ref(refname, repo_path: repo_path)
-  next if branch != 'master' # we use pull requests only for master branches
-
-  Dir.mktmpdir do |workdir|
-    # Clone a branch and fetch notes
-    depth = Git.rev_list("#{oldrev}..#{newrev}", repo_path: repo_path).size + 50
-    system('git', 'clone', "--depth=#{depth}", "--branch=#{branch}", "file://#{repo_path}", workdir)
-    Dir.chdir(workdir)
-    system('git', 'fetch', 'origin', 'refs/notes/commits:refs/notes/commits')
-
-    updated = false
-    Git.rev_list("#{oldrev}..#{newrev}", first_parent: true).each do |sha|
-      github.pulls(owner: 'ruby', repo: 'ruby', commit_sha: sha).each do |pull|
-        number = pull.fetch('number')
-        url = pull.fetch('html_url')
-        next unless url.start_with?('https://github.com/ruby/ruby/pull/')
-
-        # "Merged" notes for "Squash and merge"
-        message = Git.commit_message(sha)
-        notes = Git.notes_message(sha)
-        if !message.include?(url) && !message.match(/[ (]##{number}[) ]/) && !notes.include?(url)
-          system('git', 'notes', 'append', '-m', "Merged: #{url}", sha)
-          updated = true
-        end
-
-        # "Merged-By" notes for "Rebase and merge"
-        if Git.committer_name(sha) == 'GitHub' && Git.committer_email(sha) == '[email protected]'
-          username = github.pull_request(owner: 'ruby', repo: 'ruby', number: number).fetch('merged_by').fetch('login')
-          email = github.user(username: username).fetch('email')
-          email ||= SVN_TO_EMAILS[GITHUB_TO_SVN.fetch(username, username)]&.first
-          system('git', 'notes', 'append', '-m', "Merged-By: #{username}#{(" <#{email}>" if email)}", sha)
-          updated = true
-        end
+rest.each_slice(3).map do |oldrev, newrev, _refname|
+  system('git', 'fetch', 'origin', 'refs/notes/commits:refs/notes/commits', exception: true)
+
+  updated = false
+  Git.rev_list("#{oldrev}..#{newrev}", first_parent: true).each do |sha|
+    github.pulls(owner: 'ruby', repo: 'ruby', commit_sha: sha).each do |pull|
+      number = pull.fetch('number')
+      url = pull.fetch('html_url')
+      next unless url.start_with?('https://github.com/ruby/ruby/pull/')
+
+      # "Merged" notes for "Squash and merge"
+      message = Git.commit_message(sha)
+      notes = Git.notes_message(sha)
+      if !message.include?(url) && !message.match(/[ (]##{number}[) ]/) && !notes.include?(url)
+        system('git', 'notes', 'append', '-m', "Merged: #{url}", sha, exception: true)
+        updated = true
       end
-    end
 
-    if updated
-      system('git', 'push', 'origin', 'refs/notes/commits')
+      # "Merged-By" notes for "Rebase and merge"
+      if Git.committer_name(sha) == 'GitHub' && Git.committer_email(sha) == '[email protected]'
+        username = github.pull_request(owner: 'ruby', repo: 'ruby', number: number).fetch('merged_by').fetch('login')
+        email = github.user(username: username).fetch('email')
+        email ||= SVN_TO_EMAILS[GITHUB_TO_SVN.fetch(username, username)]&.first
+        system('git', 'notes', 'append', '-m', "Merged-By: #{username}#{(" <#{email}>" if email)}", sha, exception: true)
+        updated = true
+      end
     end
   end
+
+  if updated
+    system('git', 'push', 'origin', 'refs/notes/commits', exception: true)
+  end
 end