Skip to content

Commit d2c55e3

Browse files
committed
Remove meaningless NULL checks
The functions dereference `*dead_entry` without a NULL check
1 parent 3b27818 commit d2c55e3

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

weakmap.c

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -636,10 +636,8 @@ static int
636636
wkmap_mark_table_i(st_data_t key, st_data_t val_obj, st_data_t data)
637637
{
638638
VALUE **dead_entry = (VALUE **)data;
639-
if (dead_entry != NULL) {
640-
ruby_sized_xfree(*dead_entry, sizeof(VALUE));
641-
*dead_entry = NULL;
642-
}
639+
ruby_sized_xfree(*dead_entry, sizeof(VALUE));
640+
*dead_entry = NULL;
643641

644642
VALUE *key_ptr = (VALUE *)key;
645643

@@ -702,10 +700,8 @@ static int
702700
wkmap_compact_table_i(st_data_t key, st_data_t val_obj, st_data_t data, int _error)
703701
{
704702
VALUE **dead_entry = (VALUE **)data;
705-
if (dead_entry != NULL) {
706-
ruby_sized_xfree(*dead_entry, sizeof(VALUE));
707-
*dead_entry = NULL;
708-
}
703+
ruby_sized_xfree(*dead_entry, sizeof(VALUE));
704+
*dead_entry = NULL;
709705

710706
VALUE *key_ptr = (VALUE *)key;
711707

0 commit comments

Comments
 (0)