Skip to content

Commit eb9bc79

Browse files
nobutmm1
authored andcommitted
socket.c: format flags
* ext/socket/socket.c (rsock_syserr_fail_host_port): use format flags, '+' to inspect, ' ' to quote unprintables. * ext/socket/socket.c (rsock_syserr_fail_path): ditto. * ext/socket/socket.c (rsock_syserr_fail_raddrinfo): ditto. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@44497 b2dd03c8-39d4-4d8f-98ff-823fe69b080e Conflicts: ChangeLog
1 parent 63665b2 commit eb9bc79

File tree

1 file changed

+4
-14
lines changed

1 file changed

+4
-14
lines changed

ext/socket/socket.c

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,8 @@ rsock_syserr_fail_host_port(int err, const char *mesg, VALUE host, VALUE port)
2323
{
2424
VALUE message;
2525

26-
port = rb_String(port);
27-
28-
message = rb_sprintf("%s for \"%s\" port %s",
29-
mesg, StringValueCStr(host), StringValueCStr(port));
26+
message = rb_sprintf("%s for %+"PRIsVALUE" port % "PRIsVALUE"",
27+
mesg, host, port);
3028

3129
rb_syserr_fail_str(err, message);
3230
}
@@ -43,15 +41,7 @@ rsock_syserr_fail_path(int err, const char *mesg, VALUE path)
4341
VALUE message;
4442

4543
if (RB_TYPE_P(path, T_STRING)) {
46-
if (memchr(RSTRING_PTR(path), '\0', RSTRING_LEN(path))) {
47-
path = rb_str_inspect(path);
48-
message = rb_sprintf("%s for %s", mesg,
49-
StringValueCStr(path));
50-
}
51-
else {
52-
message = rb_sprintf("%s for \"%s\"", mesg,
53-
StringValueCStr(path));
54-
}
44+
message = rb_sprintf("%s for % "PRIsVALUE"", mesg, path);
5545
rb_syserr_fail_str(err, message);
5646
}
5747
else {
@@ -87,7 +77,7 @@ rsock_syserr_fail_raddrinfo(int err, const char *mesg, VALUE rai)
8777
VALUE str, message;
8878

8979
str = rsock_addrinfo_inspect_sockaddr(rai);
90-
message = rb_sprintf("%s for %s", mesg, StringValueCStr(str));
80+
message = rb_sprintf("%s for %"PRIsVALUE"", mesg, str);
9181

9282
rb_syserr_fail_str(err, message);
9383
}

0 commit comments

Comments
 (0)