Skip to content

Commit f4482b0

Browse files
authored
Make it easier to reproduce commands from CI (ruby#14609)
* Comment on not auto-requesting reviews for workflow files * Make it easier to reproduce matrix test_task commands from CI Expand the interpolated command so that it is easier to see exactly what command was run.
1 parent 2ad3fbb commit f4482b0

File tree

5 files changed

+15
-10
lines changed

5 files changed

+15
-10
lines changed

.github/auto_request_review.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ files:
1111
'doc/zjit*': [team:jit]
1212
'test/ruby/test_zjit*': [team:jit]
1313
'defs/jit.mk': [team:jit]
14+
# Skip github workflow files because the team don't necessarily need to review dependabot updates for GitHub Actions. It's noisy in notifications, and they're auto-merged anyway.
1415
options:
1516
ignore_draft: true
1617
# This currently doesn't work as intended. We want to skip reviews when only

.github/workflows/yjit-macos.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -145,6 +145,7 @@ jobs:
145145
test -n "${LAUNCHABLE_STDOUT}" && exec 1> >(tee "${LAUNCHABLE_STDOUT}")
146146
test -n "${LAUNCHABLE_STDERR}" && exec 2> >(tee "${LAUNCHABLE_STDERR}")
147147
148+
set -x
148149
make -s ${{ matrix.test_task }} ${TESTS:+TESTS="$TESTS"} \
149150
RUN_OPTS="$RUN_OPTS" \
150151
SPECOPTS="$SPECOPTS"

.github/workflows/yjit-ubuntu.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -195,6 +195,7 @@ jobs:
195195
test -n "${LAUNCHABLE_STDOUT}" && exec 1> >(tee "${LAUNCHABLE_STDOUT}")
196196
test -n "${LAUNCHABLE_STDERR}" && exec 2> >(tee "${LAUNCHABLE_STDERR}")
197197
198+
set -x
198199
make -s ${{ matrix.test_task }} ${TESTS:+TESTS="$TESTS"} \
199200
RUN_OPTS="$RUN_OPTS" MSPECOPT=--debug SPECOPTS="$SPECOPTS" \
200201
YJIT_BENCH_OPTS="$YJIT_BENCH_OPTS" YJIT_BINDGEN_DIFF_OPTS="$YJIT_BINDGEN_DIFF_OPTS"

.github/workflows/zjit-macos.yml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -112,11 +112,12 @@ jobs:
112112
echo "RUBY_CRASH_REPORT=$(pwd)/rb_crash_%p.txt" >> $GITHUB_ENV
113113
114114
- name: make ${{ matrix.test_task }}
115-
run: >-
116-
make -s ${{ matrix.test_task }} ${TESTS:+TESTS="$TESTS"}
117-
RUN_OPTS="$RUN_OPTS"
118-
SPECOPTS="$SPECOPTS"
119-
TESTOPTS="$TESTOPTS"
115+
run: |
116+
set -x
117+
make -s ${{ matrix.test_task }} ${TESTS:+TESTS="$TESTS"} \
118+
RUN_OPTS="$RUN_OPTS" \
119+
SPECOPTS="$SPECOPTS" \
120+
TESTOPTS="$TESTOPTS"
120121
timeout-minutes: 60
121122
env:
122123
RUBY_TESTOPTS: '-q --tty=no'

.github/workflows/zjit-ubuntu.yml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -152,11 +152,12 @@ jobs:
152152
echo "RUBY_CRASH_REPORT=$(pwd)/rb_crash_%p.txt" >> $GITHUB_ENV
153153
154154
- name: make ${{ matrix.test_task }}
155-
run: >-
156-
make -s ${{ matrix.test_task }} ${TESTS:+TESTS="$TESTS"}
157-
RUN_OPTS="$RUN_OPTS" MSPECOPT=--debug SPECOPTS="$SPECOPTS"
158-
TESTOPTS="$TESTOPTS"
159-
ZJIT_BINDGEN_DIFF_OPTS="$ZJIT_BINDGEN_DIFF_OPTS"
155+
run: |
156+
set -x
157+
make -s ${{ matrix.test_task }} ${TESTS:+TESTS="$TESTS"} \
158+
RUN_OPTS="$RUN_OPTS" MSPECOPT=--debug SPECOPTS="$SPECOPTS" \
159+
TESTOPTS="$TESTOPTS" \
160+
ZJIT_BINDGEN_DIFF_OPTS="$ZJIT_BINDGEN_DIFF_OPTS"
160161
timeout-minutes: 90
161162
env:
162163
RUBY_TESTOPTS: '-q --tty=no'

0 commit comments

Comments
 (0)