Skip to content

Commit f50f702

Browse files
committed
merge revision(s) r49221: [Backport ruby#10731]
* vm_method.c (rb_alias): raise a NameError when creating alias to a refined method if the original method of the refined method is not defined. [ruby-core:67523] [Bug ruby#10731] git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_1@49787 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
1 parent c839def commit f50f702

File tree

4 files changed

+35
-2
lines changed

4 files changed

+35
-2
lines changed

ChangeLog

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,9 @@
1+
Sun Mar 1 02:30:23 2015 Seiei Higa <[email protected]>
2+
3+
* vm_method.c (rb_alias): raise a NameError when creating alias to
4+
a refined method if the original method of the refined method is
5+
not defined. [ruby-core:67523] [Bug #10731]
6+
17
Sun Mar 1 01:17:24 2015 Seiei Higa <[email protected]>
28

39
* vm_method.c (rb_export_method): bail out if the original method

test/ruby/test_refinement.rb

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1181,6 +1181,31 @@ def foo
11811181
end;
11821182
end
11831183

1184+
def test_alias_refined_method
1185+
assert_separately([], <<-"end;")
1186+
bug10731 = '[ruby-core:67523] [Bug #10731]'
1187+
1188+
class C
1189+
end
1190+
1191+
module RefinementBug
1192+
refine C do
1193+
def foo
1194+
end
1195+
1196+
def bar
1197+
end
1198+
end
1199+
end
1200+
1201+
assert_raise(NameError, bug10731) do
1202+
class C
1203+
alias foo bar
1204+
end
1205+
end
1206+
end;
1207+
end
1208+
11841209
private
11851210

11861211
def eval_using(mod, s)

version.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#define RUBY_VERSION "2.1.5"
22
#define RUBY_RELEASE_DATE "2015-03-01"
3-
#define RUBY_PATCHLEVEL 304
3+
#define RUBY_PATCHLEVEL 305
44

55
#define RUBY_RELEASE_YEAR 2015
66
#define RUBY_RELEASE_MONTH 3

vm_method.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1259,7 +1259,9 @@ rb_alias(VALUE klass, ID name, ID def)
12591259
again:
12601260
orig_me = search_method(klass, def, &defined_class);
12611261

1262-
if (UNDEFINED_METHOD_ENTRY_P(orig_me)) {
1262+
if (UNDEFINED_METHOD_ENTRY_P(orig_me) ||
1263+
(orig_me->def->type == VM_METHOD_TYPE_REFINED &&
1264+
UNDEFINED_METHOD_ENTRY_P(orig_me->def->body.orig_me))) {
12631265
if ((!RB_TYPE_P(klass, T_MODULE)) ||
12641266
(orig_me = search_method(rb_cObject, def, 0),
12651267
UNDEFINED_METHOD_ENTRY_P(orig_me))) {

0 commit comments

Comments
 (0)