fix: fix comparison operator and remove unused files for repository variables (#798)

Author: tonpatel

lib/plugins/variables.js

@@ -40,12 +40,12 @@ module.exports = class Variables extends Diffable {
     const result =
             JSON.stringify(
               existing.sort((x1, x2) => {
-                x1.name.toUpperCase() - x2.name.toUpperCase()
+                return x1.name.toUpperCase().localeCompare(x2.name.toUpperCase())
               })
             ) !==
             JSON.stringify(
               variables.sort((x1, x2) => {
-                x1.name.toUpperCase() - x2.name.toUpperCase()
+                return x1.name.toUpperCase().localeCompare(x2.name.toUpperCase())
               })
             )
     return result
@@ -154,7 +154,7 @@ module.exports = class Variables extends Diffable {
      * @returns
      */
   async add (variable) {
-    this.log.debug(`Adding a repo var with the parms ${JSON.stringify(variable)}`)
+    this.log.debug(`Adding a repo var with the params ${JSON.stringify(variable)}`)
     await this.github
       .request('POST /repos/:org/:repo/actions/variables', {
         org: this.repo.owner,

test/fixtures/variables-config.yml

@@ -10,7 +10,7 @@ describe('Variables', () => {
     return variables
   }
 
-  function configure (config) {
+  function configure () {
     const log = { debug: console.debug, error: console.error }
     const errors = []
     return new Variables(undefined, github, { owner: org, repo }, [{ name: 'test', value: 'test' }], log, errors)